From: Loic PALLARDY <loic.pallardy@st.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>
Cc: "linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: RE: [PATCH 2/3] rpmsg: Only invoke announce_create for rpdev with endpoints
Date: Tue, 10 Apr 2018 08:22:29 +0000 [thread overview]
Message-ID: <180d35d3568c4755a76ec740142c7a59@SFHDAG7NODE2.st.com> (raw)
In-Reply-To: 20180327210643.3436-3-bjorn.andersson@linaro.org
Hi Bjorn,
> -----Original Message-----
> From: Loic PALLARDY
> Sent: Tuesday, April 03, 2018 11:13 AM
> To: 'Bjorn Andersson' <bjorn.andersson@linaro.org>; Ohad Ben-Cohen
> <ohad@wizery.com>
> Cc: linux-remoteproc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> arm-msm@vger.kernel.org
> Subject: RE: [PATCH 2/3] rpmsg: Only invoke announce_create for rpdev with
> endpoints
>
> Hi Bjorn,
>
> > -----Original Message-----
> > From: linux-remoteproc-owner@vger.kernel.org [mailto:linux-
> remoteproc-
> > owner@vger.kernel.org] On Behalf Of Bjorn Andersson
> > Sent: Tuesday, March 27, 2018 11:07 PM
> > To: Ohad Ben-Cohen <ohad@wizery.com>; Bjorn Andersson
> > <bjorn.andersson@linaro.org>
> > Cc: linux-remoteproc@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-
> > arm-msm@vger.kernel.org
> > Subject: [PATCH 2/3] rpmsg: Only invoke announce_create for rpdev with
> > endpoints
> >
> > For special rpmsg devices without a primary endpoint there is nothing to
> > announce so don't call the backend announce create function if we didn't
> > create an endpoint.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> > drivers/rpmsg/rpmsg_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
> > index dffa3aab7178..e85d2691d2cf 100644
> > --- a/drivers/rpmsg/rpmsg_core.c
> > +++ b/drivers/rpmsg/rpmsg_core.c
> > @@ -442,7 +442,7 @@ static int rpmsg_dev_probe(struct device *dev)
> > goto out;
> > }
> >
> > - if (rpdev->ops->announce_create)
> > + if (ept && rpdev->ops->announce_create)
>
> This check is already part of virtio_rpmsg.c (see line 341)
> /* need to tell remote processor's name service about this channel ?
> */
> if (rpdev->announce && rpdev->ept &&
> virtio_has_feature(vrp->vdev, VIRTIO_RPMSG_F_NS)) {
>
> should it be part of qcom_smd driver too? (but each implementation will
> duplicate checks)
> Or may have a generic check in the core including rpdev->announce as well
> (and doing virtio_rpmsg.c clean-up)
>
> Change will become:
> if (rpdev->announce && ept && rpdev->ops->announce_create)
>
> Regards,
> Loic
I'll appreciate if you reply to the review comments before merging patch and sending pull request.
Regards,
Loic
> > err = rpdev->ops->announce_create(rpdev);
> > out:
> > return err;
> > --
> > 2.16.2
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-remoteproc"
> in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-10 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 21:06 [PATCH 0/3] rpmsg: smd: Redeliver messages after probe Bjorn Andersson
2018-03-27 21:06 ` [PATCH 1/3] rpmsg: smd: Fix container_of macros Bjorn Andersson
2018-03-27 21:06 ` [PATCH 2/3] rpmsg: Only invoke announce_create for rpdev with endpoints Bjorn Andersson
2018-04-03 9:12 ` Loic PALLARDY
2018-04-10 18:27 ` Bjorn Andersson
2018-04-10 8:22 ` Loic PALLARDY [this message]
2018-03-27 21:06 ` [PATCH 3/3] rpmsg: smd: Use announce_create to process any receive work Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=180d35d3568c4755a76ec740142c7a59@SFHDAG7NODE2.st.com \
--to=loic.pallardy@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).