From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: [PATCH 0/3] rpmsg: smd: Redeliver messages after probe
Date: Tue, 27 Mar 2018 14:06:40 -0700 [thread overview]
Message-ID: <20180327210643.3436-1-bjorn.andersson@linaro.org> (raw)
A race condition exists in SMD where incoming messages might be processed
before we've finished executing the rpmsg device's probe function. The driver's
callback function will in this case be unable to handle the incoming message
and might return an error.
Using the announce_create ops we can invoke the handler for incoming messages
once again after probe returns, solving this issue.
With SMD and QRTR this shows a high failure rate, but there are (at least
theoretical) similar issues in glink and virtio-rpmsg, so this needs to be
further investigated.
Bjorn Andersson (3):
rpmsg: smd: Fix container_of macros
rpmsg: Only invoke announce_create for rpdev with endpoints
rpmsg: smd: Use announce_create to process any receive work
drivers/rpmsg/qcom_smd.c | 22 ++++++++++++++++++++--
drivers/rpmsg/rpmsg_core.c | 2 +-
2 files changed, 21 insertions(+), 3 deletions(-)
--
2.16.2
next reply other threads:[~2018-03-27 21:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 21:06 Bjorn Andersson [this message]
2018-03-27 21:06 ` [PATCH 1/3] rpmsg: smd: Fix container_of macros Bjorn Andersson
2018-03-27 21:06 ` [PATCH 2/3] rpmsg: Only invoke announce_create for rpdev with endpoints Bjorn Andersson
2018-04-03 9:12 ` Loic PALLARDY
2018-04-10 18:27 ` Bjorn Andersson
2018-04-10 8:22 ` Loic PALLARDY
2018-03-27 21:06 ` [PATCH 3/3] rpmsg: smd: Use announce_create to process any receive work Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327210643.3436-1-bjorn.andersson@linaro.org \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).