* [PATCH] crypto: rockchip - use devm_add_action_or_reset()
@ 2016-08-23 14:58 Sudip Mukherjee
2016-08-23 15:34 ` Heiko Stübner
2016-08-24 13:19 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2016-08-23 14:58 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Heiko Stuebner
Cc: linux-kernel, linux-crypto, linux-arm-kernel, linux-rockchip,
Sudip Mukherjee
If devm_add_action() fails we are explicitly calling the cleanup to free
the resources allocated. Lets use the helper devm_add_action_or_reset()
and return directly in case of error, as we know that the cleanup function
has been already called by the helper if there was any error.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
drivers/crypto/rockchip/rk3288_crypto.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c
index af50825..d0f80c6 100644
--- a/drivers/crypto/rockchip/rk3288_crypto.c
+++ b/drivers/crypto/rockchip/rk3288_crypto.c
@@ -304,11 +304,9 @@ static int rk_crypto_probe(struct platform_device *pdev)
usleep_range(10, 20);
reset_control_deassert(crypto_info->rst);
- err = devm_add_action(dev, rk_crypto_action, crypto_info);
- if (err) {
- reset_control_assert(crypto_info->rst);
+ err = devm_add_action_or_reset(dev, rk_crypto_action, crypto_info);
+ if (err)
goto err_crypto;
- }
spin_lock_init(&crypto_info->lock);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: rockchip - use devm_add_action_or_reset()
2016-08-23 14:58 [PATCH] crypto: rockchip - use devm_add_action_or_reset() Sudip Mukherjee
@ 2016-08-23 15:34 ` Heiko Stübner
2016-08-24 13:19 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2016-08-23 15:34 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Herbert Xu, David S. Miller, linux-kernel, linux-crypto,
linux-arm-kernel, linux-rockchip
Am Dienstag, 23. August 2016, 20:28:54 schrieb Sudip Mukherjee:
> If devm_add_action() fails we are explicitly calling the cleanup to free
> the resources allocated. Lets use the helper devm_add_action_or_reset()
> and return directly in case of error, as we know that the cleanup function
> has been already called by the helper if there was any error.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
nice little cleanup
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: rockchip - use devm_add_action_or_reset()
2016-08-23 14:58 [PATCH] crypto: rockchip - use devm_add_action_or_reset() Sudip Mukherjee
2016-08-23 15:34 ` Heiko Stübner
@ 2016-08-24 13:19 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2016-08-24 13:19 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: David S. Miller, Heiko Stuebner, linux-kernel, linux-crypto,
linux-arm-kernel, linux-rockchip
On Tue, Aug 23, 2016 at 08:28:54PM +0530, Sudip Mukherjee wrote:
> If devm_add_action() fails we are explicitly calling the cleanup to free
> the resources allocated. Lets use the helper devm_add_action_or_reset()
> and return directly in case of error, as we know that the cleanup function
> has been already called by the helper if there was any error.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-24 13:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-23 14:58 [PATCH] crypto: rockchip - use devm_add_action_or_reset() Sudip Mukherjee
2016-08-23 15:34 ` Heiko Stübner
2016-08-24 13:19 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).