From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Iskren Chernev <iskren.chernev@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v5 8/8] arm64: dts: qcom: sm4250: Add support for oneplus-billie2
Date: Fri, 4 Nov 2022 15:17:04 -0400 [thread overview]
Message-ID: <1880c054-08d9-3901-f44e-290d1fd27ed4@linaro.org> (raw)
In-Reply-To: <20221030094258.486428-9-iskren.chernev@gmail.com>
On 30/10/2022 05:42, Iskren Chernev wrote:
> Add initial support for OnePlus Nord N100, based on SM4250. Currently
> working:
> - boots
> - usb
> - built-in flash storage (UFS)
> - SD card reader
>
> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/sm4250-oneplus-billie2.dts | 241 ++++++++++++++++++
> 2 files changed, 242 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index b0558d3389e5..eb2a58b8af5f 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -142,6 +142,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-polaris.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-shift-axolotl.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm850-samsung-w737.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sm4250-oneplus-billie2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm6125-sony-xperia-seine-pdx201.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm6350-sony-xperia-lena-pdx213.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm7225-fairphone-fp4.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts
> new file mode 100644
> index 000000000000..a3f1c7c41fd7
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts
> @@ -0,0 +1,241 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/*
> + * Copyright (c) 2021, Iskren Chernev <iskren.chernev@gmail.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "sm4250.dtsi"
> +
> +/ {
> + model = "OnePlus Nord N100";
> + compatible = "oneplus,billie2", "qcom,sm4250";
> +
> + /* required for bootloader to select correct board */
> + qcom,msm-id = <0x1a1 0x10000 0x1bc 0x10000>;
> + qcom,board-id = <0x1000b 0x00>;
These are currently not allowed for SM4250. If there are really needed,
please justify it and update
Documentation/devicetree/bindings/arm/qcom.yaml. Then also update
include/dt-bindings/arm/qcom,ids.h and socinfo driver.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-04 19:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221030094258.486428-1-iskren.chernev@gmail.com>
2022-10-30 9:42 ` [PATCH v5 1/8] dt-bindings: ufs: qcom: Add sm6115 binding Iskren Chernev
2022-12-15 11:57 ` Bhupesh Sharma
2022-10-30 9:42 ` [PATCH v5 2/8] dt-bindings: arm: qcom: Add compatible for oneplus,billie2 phone Iskren Chernev
2022-10-30 9:42 ` [PATCH v5 3/8] dt-bindings: dmaengine: qcom: gpi: add compatible for SM6115 Iskren Chernev
2022-10-31 21:44 ` Rob Herring
2022-11-04 14:45 ` Vinod Koul
2022-10-30 9:42 ` [PATCH v5 4/8] dt-bindings: arm-smmu: Add compatible for Qualcomm SM6115 Iskren Chernev
2022-10-31 21:45 ` Rob Herring
2022-12-15 15:12 ` Dmitry Baryshkov
2022-10-30 9:42 ` [PATCH v5 5/8] iommu/arm-smmu-qcom: Add SM6115 support Iskren Chernev
2022-12-15 15:10 ` Dmitry Baryshkov
2022-12-15 15:14 ` Dmitry Baryshkov
2022-12-19 10:01 ` Iskren Chernev
2022-12-19 11:28 ` Dmitry Baryshkov
2022-10-30 9:42 ` [PATCH v5 6/8] arm64: dts: qcom: sm6115: Add basic soc dtsi Iskren Chernev
2022-10-31 21:17 ` Konrad Dybcio
2022-10-30 9:42 ` [PATCH v5 7/8] arm64: dts: qcom: sm4250: Add " Iskren Chernev
2022-10-31 21:18 ` Konrad Dybcio
2022-10-30 9:42 ` [PATCH v5 8/8] arm64: dts: qcom: sm4250: Add support for oneplus-billie2 Iskren Chernev
2022-10-31 21:21 ` Konrad Dybcio
2022-11-04 19:17 ` Krzysztof Kozlowski [this message]
2022-11-07 9:01 ` Iskren Chernev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1880c054-08d9-3901-f44e-290d1fd27ed4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=iskren.chernev@gmail.com \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).