From: Bhupesh Sharma <bhupesh.sharma@linaro.org>
To: Iskren Chernev <iskren.chernev@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/8] dt-bindings: ufs: qcom: Add sm6115 binding
Date: Thu, 15 Dec 2022 17:27:57 +0530 [thread overview]
Message-ID: <1d3d8169-1011-cdfd-f9f7-b7828acdc1ac@linaro.org> (raw)
In-Reply-To: <20221030094258.486428-2-iskren.chernev@gmail.com>
On 10/30/22 3:12 PM, Iskren Chernev wrote:
> Add SM6115 UFS to DT schema.
>
> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/ufs/qcom,ufs.yaml | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> index f2d6298d926c..b517d76215e3 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> @@ -28,6 +28,7 @@ properties:
> - qcom,msm8998-ufshc
> - qcom,sc8280xp-ufshc
> - qcom,sdm845-ufshc
> + - qcom,sm6115-ufshc
> - qcom,sm6350-ufshc
> - qcom,sm8150-ufshc
> - qcom,sm8250-ufshc
> @@ -178,6 +179,31 @@ allOf:
> minItems: 1
> maxItems: 1
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sm6115-ufshc
> + then:
> + properties:
> + clocks:
> + minItems: 8
> + maxItems: 8
> + clock-names:
> + items:
> + - const: core_clk
> + - const: bus_aggr_clk
> + - const: iface_clk
> + - const: core_clk_unipro
> + - const: ref_clk
> + - const: tx_lane0_sync_clk
> + - const: rx_lane0_sync_clk
> + - const: ice_core_clk
> + reg:
> + minItems: 2
> + maxItems: 2
> +
> # TODO: define clock bindings for qcom,msm8994-ufshc
>
> unevaluatedProperties: false
Seems this hasn't made way to linux-next yet. Hence we get the following
error with $ make dtbs_check:
arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dtb: ufs@4804000:
compatible:0: 'qcom,sm6115-ufshc' is not one of ['qcom,msm8994-ufshc',
'qcom,msm8996-ufshc', 'qcom,msm8998-ufshc', 'qcom,sc8280xp-ufshc',
'qcom,sdm845-ufshc', 'qcom,sm6350-ufshc', 'qcom,sm8150-ufshc',
'qcom,sm8250-ufshc', 'qcom,sm8350-ufshc', 'qcom,sm8450-ufshc']
From schema: Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dtb: ufs@4804000:
Unevaluated properties are not allowed ('compatible' was unexpected)
From schema: Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
If, it helps to get the review / merge happen:
Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
@Rob, @Krzysztof: Please help merge this.
Thanks.
next prev parent reply other threads:[~2022-12-15 11:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221030094258.486428-1-iskren.chernev@gmail.com>
2022-10-30 9:42 ` [PATCH v5 1/8] dt-bindings: ufs: qcom: Add sm6115 binding Iskren Chernev
2022-12-15 11:57 ` Bhupesh Sharma [this message]
2022-10-30 9:42 ` [PATCH v5 2/8] dt-bindings: arm: qcom: Add compatible for oneplus,billie2 phone Iskren Chernev
2022-10-30 9:42 ` [PATCH v5 3/8] dt-bindings: dmaengine: qcom: gpi: add compatible for SM6115 Iskren Chernev
2022-10-31 21:44 ` Rob Herring
2022-11-04 14:45 ` Vinod Koul
2022-10-30 9:42 ` [PATCH v5 4/8] dt-bindings: arm-smmu: Add compatible for Qualcomm SM6115 Iskren Chernev
2022-10-31 21:45 ` Rob Herring
2022-12-15 15:12 ` Dmitry Baryshkov
2022-10-30 9:42 ` [PATCH v5 5/8] iommu/arm-smmu-qcom: Add SM6115 support Iskren Chernev
2022-12-15 15:10 ` Dmitry Baryshkov
2022-12-15 15:14 ` Dmitry Baryshkov
2022-12-19 10:01 ` Iskren Chernev
2022-12-19 11:28 ` Dmitry Baryshkov
2022-10-30 9:42 ` [PATCH v5 6/8] arm64: dts: qcom: sm6115: Add basic soc dtsi Iskren Chernev
2022-10-31 21:17 ` Konrad Dybcio
2022-10-30 9:42 ` [PATCH v5 7/8] arm64: dts: qcom: sm4250: Add " Iskren Chernev
2022-10-31 21:18 ` Konrad Dybcio
2022-10-30 9:42 ` [PATCH v5 8/8] arm64: dts: qcom: sm4250: Add support for oneplus-billie2 Iskren Chernev
2022-10-31 21:21 ` Konrad Dybcio
2022-11-04 19:17 ` Krzysztof Kozlowski
2022-11-07 9:01 ` Iskren Chernev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d3d8169-1011-cdfd-f9f7-b7828acdc1ac@linaro.org \
--to=bhupesh.sharma@linaro.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=devicetree@vger.kernel.org \
--cc=iskren.chernev@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).