* [PATCH net-next] net: macb: make magic-packet property generic
@ 2016-02-16 0:13 Sergio Prado
2016-02-16 9:12 ` Arnd Bergmann
2016-02-16 14:23 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Sergio Prado @ 2016-02-16 0:13 UTC (permalink / raw)
To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
nicolas.ferre, davem, gregory.clement, narmstrong, michal.simek,
harini.katakam, boris.brezillon, devicetree, linux-kernel,
netdev
Cc: Sergio Prado
Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
---
As requested by Rob Herring on patch
https://patchwork.ozlabs.org/patch/580862/
---
Documentation/devicetree/bindings/net/macb.txt | 2 +-
drivers/net/ethernet/cadence/macb.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
index c6b1cb5ffa87..b5a42df4c928 100644
--- a/Documentation/devicetree/bindings/net/macb.txt
+++ b/Documentation/devicetree/bindings/net/macb.txt
@@ -25,7 +25,7 @@ Required properties:
Optional properties for PHY child node:
- reset-gpios : Should specify the gpio for phy reset
-- cdns,magic-packet : If present, indicates that the hardware supports waking
+- magic-packet : If present, indicates that the hardware supports waking
up via magic packet.
Examples:
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 69af049e55a8..7ccf2298a5fa 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -2929,7 +2929,7 @@ static int macb_probe(struct platform_device *pdev)
bp->jumbo_max_len = macb_config->jumbo_max_len;
bp->wol = 0;
- if (of_get_property(np, "cdns,magic-packet", NULL))
+ if (of_get_property(np, "magic-packet", NULL))
bp->wol |= MACB_WOL_HAS_MAGIC_PACKET;
device_init_wakeup(&pdev->dev, bp->wol & MACB_WOL_HAS_MAGIC_PACKET);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: macb: make magic-packet property generic
2016-02-16 0:13 [PATCH net-next] net: macb: make magic-packet property generic Sergio Prado
@ 2016-02-16 9:12 ` Arnd Bergmann
2016-02-16 14:23 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-02-16 9:12 UTC (permalink / raw)
To: Sergio Prado
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
nicolas.ferre, davem, gregory.clement, narmstrong, michal.simek,
harini.katakam, boris.brezillon, devicetree, linux-kernel,
netdev
On Monday 15 February 2016 22:13:58 Sergio Prado wrote:
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> ---
> As requested by Rob Herring on patch
> https://patchwork.ozlabs.org/patch/580862/
>
This needs a changelog comment, at least clarify that the existing
value has never been used in production, so we are not breaking
anything with the incompatible binding change.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: macb: make magic-packet property generic
2016-02-16 0:13 [PATCH net-next] net: macb: make magic-packet property generic Sergio Prado
2016-02-16 9:12 ` Arnd Bergmann
@ 2016-02-16 14:23 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2016-02-16 14:23 UTC (permalink / raw)
To: Sergio Prado, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, nicolas.ferre, davem, gregory.clement, narmstrong,
michal.simek, harini.katakam, boris.brezillon, devicetree,
linux-kernel, netdev
Hello.
On 2/16/2016 3:13 AM, Sergio Prado wrote:
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> ---
> As requested by Rob Herring on patch
> https://patchwork.ozlabs.org/patch/580862/
> ---
> Documentation/devicetree/bindings/net/macb.txt | 2 +-
> drivers/net/ethernet/cadence/macb.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index c6b1cb5ffa87..b5a42df4c928 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -25,7 +25,7 @@ Required properties:
>
> Optional properties for PHY child node:
> - reset-gpios : Should specify the gpio for phy reset
> -- cdns,magic-packet : If present, indicates that the hardware supports waking
> +- magic-packet : If present, indicates that the hardware supports waking
> up via magic packet.
>
> Examples:
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 69af049e55a8..7ccf2298a5fa 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -2929,7 +2929,7 @@ static int macb_probe(struct platform_device *pdev)
> bp->jumbo_max_len = macb_config->jumbo_max_len;
>
> bp->wol = 0;
> - if (of_get_property(np, "cdns,magic-packet", NULL))
> + if (of_get_property(np, "magic-packet", NULL))
Could as well use of_property_read_bool().
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-16 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-16 0:13 [PATCH net-next] net: macb: make magic-packet property generic Sergio Prado
2016-02-16 9:12 ` Arnd Bergmann
2016-02-16 14:23 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).