* [PATCH] staging: tegra-video: fix V4L2 dependency
@ 2020-05-27 22:13 Arnd Bergmann
2020-05-28 22:16 ` Sowjanya Komatineni
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2020-05-27 22:13 UTC (permalink / raw)
To: soc, Thierry Reding, Jonathan Hunter, Sowjanya Komatineni
Cc: Arnd Bergmann, Thierry Reding, Dmitry Osipenko, Hans Verkuil,
Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-tegra, devel, linux-kernel
Rather than using a dependency on VIDEO_V4L2, this driver uses
"select", which fails when other dependencies are missing:
WARNING: unmet direct dependencies detected for VIDEO_V4L2
Depends on [n]: MEDIA_SUPPORT [=y] && (I2C [=y] || I2C [=y]=n) && VIDEO_DEV [=n]
Selected by [y]:
- VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && TEGRA_HOST1X [=y]
(plus an endless stream of link errors for other drivers that
depend on VIDEO_V4L2 but are now lacking their dependencies)
Fixes: 3d8a97eabef0 ("media: tegra-video: Add Tegra210 Video input driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/media/tegra-video/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/tegra-video/Kconfig b/drivers/staging/media/tegra-video/Kconfig
index 3f03b5b39e6c..f6c61ec74386 100644
--- a/drivers/staging/media/tegra-video/Kconfig
+++ b/drivers/staging/media/tegra-video/Kconfig
@@ -2,7 +2,7 @@
config VIDEO_TEGRA
tristate "NVIDIA Tegra VI driver"
depends on TEGRA_HOST1X
- select VIDEO_V4L2
+ depends on VIDEO_V4L2
select MEDIA_CONTROLLER
select VIDEOBUF2_DMA_CONTIG
help
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: tegra-video: fix V4L2 dependency
2020-05-27 22:13 [PATCH] staging: tegra-video: fix V4L2 dependency Arnd Bergmann
@ 2020-05-28 22:16 ` Sowjanya Komatineni
0 siblings, 0 replies; 2+ messages in thread
From: Sowjanya Komatineni @ 2020-05-28 22:16 UTC (permalink / raw)
To: Arnd Bergmann, soc, Thierry Reding, Jonathan Hunter
Cc: Thierry Reding, Dmitry Osipenko, Hans Verkuil,
Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-tegra, devel, linux-kernel
On 5/27/20 3:13 PM, Arnd Bergmann wrote:
> Rather than using a dependency on VIDEO_V4L2, this driver uses
> "select", which fails when other dependencies are missing:
>
> WARNING: unmet direct dependencies detected for VIDEO_V4L2
> Depends on [n]: MEDIA_SUPPORT [=y] && (I2C [=y] || I2C [=y]=n) && VIDEO_DEV [=n]
> Selected by [y]:
> - VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && TEGRA_HOST1X [=y]
> (plus an endless stream of link errors for other drivers that
> depend on VIDEO_V4L2 but are now lacking their dependencies)
>
> Fixes: 3d8a97eabef0 ("media: tegra-video: Add Tegra210 Video input driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/media/tegra-video/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/tegra-video/Kconfig b/drivers/staging/media/tegra-video/Kconfig
> index 3f03b5b39e6c..f6c61ec74386 100644
> --- a/drivers/staging/media/tegra-video/Kconfig
> +++ b/drivers/staging/media/tegra-video/Kconfig
> @@ -2,7 +2,7 @@
> config VIDEO_TEGRA
> tristate "NVIDIA Tegra VI driver"
> depends on TEGRA_HOST1X
> - select VIDEO_V4L2
> + depends on VIDEO_V4L2
> select MEDIA_CONTROLLER
> select VIDEOBUF2_DMA_CONTIG
> help
Acked-by: Sowjanya Komatineni <skomatineni@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-28 22:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 22:13 [PATCH] staging: tegra-video: fix V4L2 dependency Arnd Bergmann
2020-05-28 22:16 ` Sowjanya Komatineni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).