* [PATCH] drivers/clocksource/fttmr010: Factor clock read code
@ 2017-06-13 21:48 Linus Walleij
2017-06-14 8:38 ` Daniel Lezcano
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2017-06-13 21:48 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, Joel Stanley, Jonas Jensen
Cc: Janos Laube, Paulius Zaleckas, linux-arm-kernel, Hans Ulli Kroll,
Florian Fainelli, linux-kernel, Linus Walleij, Andrew Jeffery
The sched_clock() and delay timer callbacks can just call
each other and we can save an #ifdef.
Suggested-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: Joel Stanley <joel@jms.id.au>
Cc: Jonas Jensen <jonas.jensen@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Daniel: feel free to apply as-is or squash into the other
patch as you like.
---
drivers/clocksource/timer-fttmr010.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/clocksource/timer-fttmr010.c b/drivers/clocksource/timer-fttmr010.c
index 0074d89cd2ce..bb07787229b6 100644
--- a/drivers/clocksource/timer-fttmr010.c
+++ b/drivers/clocksource/timer-fttmr010.c
@@ -98,30 +98,26 @@ static inline struct fttmr010 *to_fttmr010(struct clock_event_device *evt)
return container_of(evt, struct fttmr010, clkevt);
}
-static u64 notrace fttmr010_read_sched_clock_up(void)
+static unsigned long fttmr010_read_current_timer_up(void)
{
return readl(local_fttmr->base + TIMER2_COUNT);
}
-static u64 notrace fttmr010_read_sched_clock_down(void)
+static unsigned long fttmr010_read_current_timer_down(void)
{
return ~readl(local_fttmr->base + TIMER2_COUNT);
}
-#ifdef CONFIG_ARM
-
-static unsigned long fttmr010_read_current_timer_up(void)
+static u64 notrace fttmr010_read_sched_clock_up(void)
{
- return readl(local_fttmr->base + TIMER2_COUNT);
+ return fttmr010_read_current_timer_up();
}
-static unsigned long fttmr010_read_current_timer_down(void)
+static u64 notrace fttmr010_read_sched_clock_down(void)
{
- return ~readl(local_fttmr->base + TIMER2_COUNT);
+ return fttmr010_read_current_timer_down();
}
-#endif
-
static int fttmr010_timer_set_next_event(unsigned long cycles,
struct clock_event_device *evt)
{
--
2.9.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/clocksource/fttmr010: Factor clock read code
2017-06-13 21:48 [PATCH] drivers/clocksource/fttmr010: Factor clock read code Linus Walleij
@ 2017-06-14 8:38 ` Daniel Lezcano
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2017-06-14 8:38 UTC (permalink / raw)
To: Linus Walleij, Thomas Gleixner, Joel Stanley, Jonas Jensen
Cc: Janos Laube, Paulius Zaleckas, linux-arm-kernel, Hans Ulli Kroll,
Florian Fainelli, linux-kernel, Andrew Jeffery
On 13/06/2017 23:48, Linus Walleij wrote:
> The sched_clock() and delay timer callbacks can just call
> each other and we can save an #ifdef.
>
> Suggested-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Jonas Jensen <jonas.jensen@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Daniel: feel free to apply as-is or squash into the other
> patch as you like.
> ---
> drivers/clocksource/timer-fttmr010.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
Applied thanks!
-- Daniel
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-14 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-13 21:48 [PATCH] drivers/clocksource/fttmr010: Factor clock read code Linus Walleij
2017-06-14 8:38 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).