* [PATCH] drivers: watchdog: booke_wdt: add __ro_after_init to booke_wdt_info
@ 2016-12-24 16:07 Bhumika Goyal
2016-12-24 16:19 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Bhumika Goyal @ 2016-12-24 16:07 UTC (permalink / raw)
To: julia.lawall, wim, linux, linux-watchdog, linux-kernel
Cc: keescook, Bhumika Goyal
The object booke_wdt_info of watchdog_info structure is not
modified after getting initialized by booke_wdt_init. Apart from getting
referenced in init it is also stored in the info field of watchdog_device
structure which is of type const struct watchdog_info *info. So, it
becomes read only after init and therefore add __ro_after_init to it's
declaration.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/watchdog/booke_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
index 04da4b6..ae034bb 100644
--- a/drivers/watchdog/booke_wdt.c
+++ b/drivers/watchdog/booke_wdt.c
@@ -192,7 +192,7 @@ static int booke_wdt_set_timeout(struct watchdog_device *wdt_dev,
return 0;
}
-static struct watchdog_info booke_wdt_info = {
+static struct watchdog_info booke_wdt_info __ro_after_init = {
.options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
.identity = "PowerPC Book-E Watchdog",
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: watchdog: booke_wdt: add __ro_after_init to booke_wdt_info
2016-12-24 16:07 [PATCH] drivers: watchdog: booke_wdt: add __ro_after_init to booke_wdt_info Bhumika Goyal
@ 2016-12-24 16:19 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2016-12-24 16:19 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, wim, linux-watchdog, linux-kernel; +Cc: keescook
On 12/24/2016 08:07 AM, Bhumika Goyal wrote:
> The object booke_wdt_info of watchdog_info structure is not
> modified after getting initialized by booke_wdt_init. Apart from getting
> referenced in init it is also stored in the info field of watchdog_device
> structure which is of type const struct watchdog_info *info. So, it
> becomes read only after init and therefore add __ro_after_init to it's
> declaration.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/booke_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
> index 04da4b6..ae034bb 100644
> --- a/drivers/watchdog/booke_wdt.c
> +++ b/drivers/watchdog/booke_wdt.c
> @@ -192,7 +192,7 @@ static int booke_wdt_set_timeout(struct watchdog_device *wdt_dev,
> return 0;
> }
>
> -static struct watchdog_info booke_wdt_info = {
> +static struct watchdog_info booke_wdt_info __ro_after_init = {
> .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
> .identity = "PowerPC Book-E Watchdog",
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-24 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-24 16:07 [PATCH] drivers: watchdog: booke_wdt: add __ro_after_init to booke_wdt_info Bhumika Goyal
2016-12-24 16:19 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).