linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: mturquette@linaro.org
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	shawn.guo@linaro.org, festevam@gmail.com, harald@ccbib.org,
	linux-arm-kernel@lists.infradead.org, Marek Vasut <marex@denx.de>
Subject: Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers
Date: Tue, 20 Jan 2015 19:35:09 +0100 (CET)	[thread overview]
Message-ID: <1913991589.463352.1421778909585.JavaMail.open-xchange@oxbaltgw06.schlund.de> (raw)
In-Reply-To: <201412281930.17676.marex@denx.de>

Hi,

> Marek Vasut <marex@denx.de> hat am 28. Dezember 2014 um 19:30 geschrieben:
>
>
> On Sunday, December 28, 2014 at 11:26:42 AM, Stefan Wahren wrote:
> > According to i.MX23 and i.MX28 reference manual the fractional
> > clock control registers must be addressed by byte instructions.
> >
> > This patch fixes the erroneous 32-bit access to these registers
> > and extends the comment in the init functions.
> >
> > Btw the imx23 init now uses a R-M-W sequence just like imx28 init
> > to avoid any clock glitches.
> >
> > The changes has been tested only with a i.MX28 board, because i don't
> > have access to an i.MX23 board.

since i've also a i.MX23 board, i tested this patch successful.

Any conserns about it?

> >
> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>
> I don't see a problem,
>
> Reviewed-by: Marek Vasut <marex@denx.de>
>
> Best regards,
> Marek Vasut
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2015-01-20 18:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-28 10:26 [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers Stefan Wahren
2014-12-28 18:30 ` Marek Vasut
2015-01-20 18:35   ` Stefan Wahren [this message]
2015-01-21 16:16 ` Zhi Li
2015-01-21 23:39   ` Marek Vasut
2015-01-28  1:51     ` Mike Turquette
2015-01-28  3:36       ` Zhi Li
2015-01-28 15:52         ` Stefan Wahren
2015-01-28 16:10           ` Zhi Li
2015-01-28 16:40             ` Stefan Wahren
2015-01-28 20:52               ` Zhi Li
2015-01-28 20:55 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1913991589.463352.1421778909585.JavaMail.open-xchange@oxbaltgw06.schlund.de \
    --to=stefan.wahren@i2se.com \
    --cc=festevam@gmail.com \
    --cc=harald@ccbib.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=mturquette@linaro.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).