From: Fabio Estevam <festevam@gmail.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: "Mike Turquette" <mturquette@linaro.org>,
"Shawn Guo" <shawn.guo@linaro.org>, "Marek Vašut" <marex@denx.de>,
harald@ccbib.org, "Sascha Hauer" <kernel@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers
Date: Wed, 28 Jan 2015 18:55:25 -0200 [thread overview]
Message-ID: <CAOMZO5CQVHD2bJbh4whmd7yxq0Mia7Gr+53W7z5pE+GrAkszgw@mail.gmail.com> (raw)
In-Reply-To: <1419762402-4548-1-git-send-email-stefan.wahren@i2se.com>
Hi Stefan,
On Sun, Dec 28, 2014 at 8:26 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> According to i.MX23 and i.MX28 reference manual the fractional
> clock control registers must be addressed by byte instructions.
>
> This patch fixes the erroneous 32-bit access to these registers
> and extends the comment in the init functions.
>
> Btw the imx23 init now uses a R-M-W sequence just like imx28 init
> to avoid any clock glitches.
>
> The changes has been tested only with a i.MX28 board, because i don't
> have access to an i.MX23 board.
As you recently had a chance to test it on mx23, maybe you could
resend it and change this last parapgraph.
Regards,
Fabio Estevam
prev parent reply other threads:[~2015-01-28 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 10:26 [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers Stefan Wahren
2014-12-28 18:30 ` Marek Vasut
2015-01-20 18:35 ` Stefan Wahren
2015-01-21 16:16 ` Zhi Li
2015-01-21 23:39 ` Marek Vasut
2015-01-28 1:51 ` Mike Turquette
2015-01-28 3:36 ` Zhi Li
2015-01-28 15:52 ` Stefan Wahren
2015-01-28 16:10 ` Zhi Li
2015-01-28 16:40 ` Stefan Wahren
2015-01-28 20:52 ` Zhi Li
2015-01-28 20:55 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5CQVHD2bJbh4whmd7yxq0Mia7Gr+53W7z5pE+GrAkszgw@mail.gmail.com \
--to=festevam@gmail.com \
--cc=harald@ccbib.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mturquette@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).