From: Markus Elfring <Markus.Elfring@web.de>
To: Wei Yongjun <weiyongjun1@huawei.com>,
linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Jassi Brar <jassisinghbrar@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Wendy Liang <wendy.liang@xilinx.com>
Subject: Re: [PATCH] mailbox: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe()
Date: Wed, 29 Apr 2020 11:13:15 +0200 [thread overview]
Message-ID: <1931070d-77fe-996c-3ce4-5400b1bd72cd@web.de> (raw)
> In case of error, the function devm_ioremap() returns NULL pointer
> not ERR_PTR().
Such information is helpful.
> The IS_ERR() test in the return value check should be replaced with NULL test.
Would you like to convert this description into an imperative wording?
Regards,
Markus
reply other threads:[~2020-04-29 9:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1931070d-77fe-996c-3ce4-5400b1bd72cd@web.de \
--to=markus.elfring@web.de \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=weiyongjun1@huawei.com \
--cc=wendy.liang@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).