linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] mailbox: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe()
@ 2020-04-29  9:13 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-04-29  9:13 UTC (permalink / raw)
  To: Wei Yongjun, linux-arm-kernel
  Cc: kernel-janitors, linux-kernel, Jassi Brar, Michal Simek, Wendy Liang

> In case of error, the function devm_ioremap() returns NULL pointer
> not ERR_PTR().

Such information is helpful.


> The IS_ERR() test in the return value check should be replaced with NULL test.

Would you like to convert this description into an imperative wording?

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-04-29  9:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29  9:13 [PATCH] mailbox: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe() Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).