* Re: [PATCH] phy-rockchip-pcie: remove deassert of phy_rst from exit callback
[not found] <1476333733-9696-1-git-send-email-shawn.lin@rock-chips.com>
@ 2016-10-28 8:31 ` Heiko Stuebner
2016-11-05 5:48 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Stuebner @ 2016-10-28 8:31 UTC (permalink / raw)
To: Shawn Lin
Cc: Kishon Vijay Abraham I, linux-kernel, linux-rockchip, Jeffy Chen,
Wenrui Li, Brian Norris
Am Donnerstag, 13. Oktober 2016, 12:42:13 CEST schrieb Shawn Lin:
> The deassert of phy_rst from exit callback is incorrect as when
> doing phy_exit, we expect the phy_rst is on asserted state which was
> done by power_off callback, but not deasserted state. Meanwhile when
> disabling clk_pciephy_ref, the assert/deassert signal can't actually
> take effect on the phy. So let's fix it anyway.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
looks ok to have that removed, as any future phy_init call will make sure it
gets asserted anyway.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] phy-rockchip-pcie: remove deassert of phy_rst from exit callback
2016-10-28 8:31 ` [PATCH] phy-rockchip-pcie: remove deassert of phy_rst from exit callback Heiko Stuebner
@ 2016-11-05 5:48 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 2+ messages in thread
From: Kishon Vijay Abraham I @ 2016-11-05 5:48 UTC (permalink / raw)
To: Heiko Stuebner, Shawn Lin
Cc: linux-kernel, linux-rockchip, Jeffy Chen, Wenrui Li, Brian Norris
On Friday 28 October 2016 02:01 PM, Heiko Stuebner wrote:
> Am Donnerstag, 13. Oktober 2016, 12:42:13 CEST schrieb Shawn Lin:
>> The deassert of phy_rst from exit callback is incorrect as when
>> doing phy_exit, we expect the phy_rst is on asserted state which was
>> done by power_off callback, but not deasserted state. Meanwhile when
>> disabling clk_pciephy_ref, the assert/deassert signal can't actually
>> take effect on the phy. So let's fix it anyway.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> looks ok to have that removed, as any future phy_init call will make sure it
> gets asserted anyway.
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
merged, thanks.
-Kishon
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-05 5:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1476333733-9696-1-git-send-email-shawn.lin@rock-chips.com>
2016-10-28 8:31 ` [PATCH] phy-rockchip-pcie: remove deassert of phy_rst from exit callback Heiko Stuebner
2016-11-05 5:48 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).