Re: hns3: Compilation of hns3_enet.c is triggered without changes

* Re: hns3: Compilation of hns3_enet.c is triggered without changes
       [not found] <430207483.256478.1546089053476@email.ionos.de>
@ 2019-01-02 10:44 ` John Garry
  0 siblings, 0 replies; only message in thread
From: John Garry @ 2019-01-02 10:44 UTC (permalink / raw)
  To: Stefan Wahren, Yisen Zhuang, Salil Mehta; +Cc: netdev, Linuxarm, linux-kernel

On 29/12/2018 13:10, Stefan Wahren wrote:
> Hi,
>
> during development i noticed that hns3_enet.c is compiled even without any changes to this file.
>
> I think the reason for this is the usage of VERMAGIC_STRING in this file. So it would be nice if you could somehow replace this define.
>
> Kind regards
> Stefan
>
>

I reported this issue internally some time ago. Apparently it is 
required to reference VERMAGIC_STRING, but I don't know why.

I see that this driver has similar issue:
https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/netronome/nfp/nfp_main.c#L34

Another annoying thing I find is the amount of references to UTS_RELEASE 
(which also causes rebuilds), like:
https://elixir.bootlin.com/linux/latest/source/drivers/base/firmware_loader/main.c#L281

Can't we just make a static string for these, to save the rebuilding the 
dependent modules?

Thanks,
John

^ permalink raw reply	[flat|nested] only message in thread