From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Markuss Broks" <markuss.broks@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Alexandru Tachici" <alexandru.tachici@analog.com>,
"Marcelo Schmitt" <marcelo.schmitt1@gmail.com>,
"Tomislav Denis" <tomislav.denis@avl.com>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
"Nishant Malpani" <nish.malpani25@gmail.com>,
"Dragos Bogdan" <dragos.bogdan@analog.com>,
"Nuno Sa" <nuno.sa@analog.com>,
"Jean-Baptiste Maneyrol" <jmaneyrol@invensense.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Mark Brown" <broonie@kernel.org>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Marek Belisko" <marek@goldelico.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
"Christian Eggers" <ceggers@arri.de>,
"Beniamin Bia" <beniamin.bia@analog.com>,
"Stefan Popa" <stefan.popa@analog.com>,
"Oskar Andero" <oskar.andero@gmail.com>,
"Mårten Lindahl" <martenli@axis.com>,
"Dan Murphy" <dmurphy@ti.com>, "Sean Nyekjaer" <sean@geanix.com>,
"Cristian Pop" <cristian.pop@analog.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Matt Ranostay" <matt.ranostay@konsulko.com>,
"Matheus Tavares" <matheus.bernardino@usp.br>,
"Sankar Velliangiri" <navin@linumiz.com>,
"Lubomir Rintel" <lkundrak@v3.sk>,
"Stefan Wahren" <stefan.wahren@in-tech.com>,
"Pratyush Yadav" <p.yadav@ti.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-fbdev@vger.kernel.org, netdev@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: panel: explicitly list SPI CPHA and CPOL
Date: Fri, 22 Jul 2022 20:37:49 +0200 [thread overview]
Message-ID: <1a03d894-3f4c-fb57-5f05-ad7bf11f5488@linaro.org> (raw)
In-Reply-To: <20220721193004.GA1783390-robh@kernel.org>
On 21/07/2022 21:30, Rob Herring wrote:
> On Thu, Jul 21, 2022 at 05:31:50PM +0200, Krzysztof Kozlowski wrote:
>> The spi-cpha and spi-cpol properties are device specific and should be
>> accepted only if device really needs them. Explicitly list them in
>> device bindings in preparation of their removal from generic
>> spi-peripheral-props.yaml schema.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> .../bindings/display/panel/lgphilips,lb035q02.yaml | 10 ++++++++++
>> .../bindings/display/panel/samsung,ld9040.yaml | 10 ++++++++++
>> .../bindings/display/panel/samsung,lms380kf01.yaml | 12 +++++++++---
>> .../bindings/display/panel/samsung,lms397kf04.yaml | 12 +++++++++---
>> .../bindings/display/panel/samsung,s6d27a1.yaml | 12 +++++++++---
>> .../bindings/display/panel/sitronix,st7789v.yaml | 10 ++++++++++
>> .../devicetree/bindings/display/panel/tpo,td.yaml | 10 ++++++++++
>> 7 files changed, 67 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
>> index 5e4e0e552c2f..0bd7bbad5b94 100644
>> --- a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
>> @@ -21,6 +21,16 @@ properties:
>> enable-gpios: true
>> port: true
>>
>> + spi-cpha:
>> + type: boolean
>> + description:
>> + The device requires shifted clock phase (CPHA) mode.
>> +
>> + spi-cpol:
>> + type: boolean
>> + description:
>> + The device requires inverse clock polarity (CPOL) mode.
>
> Not great duplicating the type and description everywhere.
>
> We can move the definition back to spi-controller.yaml, so then that
> does type checking of the property, but not presence/absence checks.
If I understand correctly, all client devices (which do no reference
spi-controller) will need to explicitly mention CPHA/CPOL. Good idea.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-22 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 15:31 [PATCH 0/6] dt-bindings: iio/panel/eeprom/misc/net/spi: drop SPI CPHA and CPOL Krzysztof Kozlowski
2022-07-21 15:31 ` [PATCH 1/6] dt-bindings: panel: explicitly list " Krzysztof Kozlowski
2022-07-21 19:30 ` Rob Herring
2022-07-22 18:37 ` Krzysztof Kozlowski [this message]
2022-07-21 15:31 ` [PATCH 2/6] dt-bindings: eeprom: at25: " Krzysztof Kozlowski
2022-07-21 15:31 ` [PATCH 3/6] dt-bindings: iio: " Krzysztof Kozlowski
2022-07-21 19:32 ` Rob Herring
2022-07-21 15:31 ` [PATCH 4/6] dt-bindings: misc: " Krzysztof Kozlowski
2022-07-21 15:31 ` [PATCH 5/6] dt-bindings: net: " Krzysztof Kozlowski
2022-07-21 19:35 ` Rob Herring
2022-07-21 15:31 ` [PATCH 6/6] spi: dt-bindings: drop CPHA and CPOL from common properties Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a03d894-3f4c-fb57-5f05-ad7bf11f5488@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Michael.Hennerich@analog.com \
--cc=airlied@linux.ie \
--cc=alexandru.tachici@analog.com \
--cc=andrzej.hajda@intel.com \
--cc=beniamin.bia@analog.com \
--cc=broonie@kernel.org \
--cc=ceggers@arri.de \
--cc=cosmin.tanislav@analog.com \
--cc=cristian.pop@analog.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dragos.bogdan@analog.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=hns@goldelico.com \
--cc=jic23@kernel.org \
--cc=jmaneyrol@invensense.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=lukas@wunner.de \
--cc=marcelo.schmitt1@gmail.com \
--cc=marek@goldelico.com \
--cc=markuss.broks@gmail.com \
--cc=martenli@axis.com \
--cc=matheus.bernardino@usp.br \
--cc=matt.ranostay@konsulko.com \
--cc=mripard@kernel.org \
--cc=navin@linumiz.com \
--cc=netdev@vger.kernel.org \
--cc=nish.malpani25@gmail.com \
--cc=nuno.sa@analog.com \
--cc=oskar.andero@gmail.com \
--cc=p.yadav@ti.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=sean@geanix.com \
--cc=stefan.popa@analog.com \
--cc=stefan.wahren@in-tech.com \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=tomislav.denis@avl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).