From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Yong Wu <yong.wu@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
anan.sun@mediatek.com, ming-fan.chen@mediatek.com,
yi.kuo@mediatek.com, anthony.huang@mediatek.com,
Ikjoon Jang <ikjn@chromium.org>
Subject: Re: [PATCH v3 00/13] MT8195 SMI support
Date: Wed, 18 Aug 2021 22:41:40 +0200 [thread overview]
Message-ID: <1a160afd-ceeb-04a3-8213-fe781ec18e30@canonical.com> (raw)
In-Reply-To: <20210810080859.29511-1-yong.wu@mediatek.com>
On 10/08/2021 10:08, Yong Wu wrote:
> This patchset mainly adds SMI support for mt8195.
>
> Comparing with the previous version, add two new functions:
> a) add smi sub common
> b) add initial setting for smi-common and smi-larb.
>
> Change note:
> v3:1) In the dt-binding:
> a. Change mediatek,smi type from phandle-array to phandle from Rob.
> b. Add a new bool property (mediatek,smi_sub_common)
> to indicate if this is smi-sub-common.
> 2) Change the clock using bulk parting.
> keep the smi-common's has_gals flag. more strict.
> 3) More comment about larb initial setting.
> 4) Add a maintain patch
The patchset looks good to me but I saw now comments from Rob, so I
expect a resend. Therefore there is also time for additional review -
maybe continued by Ikjoon Jang?
If you sent a v4 with fixes rather soon and get ack from Rob, I could
still try to get it into next merge window. After this weekend I won't
be taking patches for this cycle and it will wait for the merge window
to finish.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-08-18 20:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 8:08 [PATCH v3 00/13] MT8195 SMI support Yong Wu
2021-08-10 8:08 ` [PATCH v3 01/13] dt-bindings: memory: mediatek: Add mt8195 smi binding Yong Wu
2021-08-10 8:08 ` [PATCH v3 02/13] dt-bindings: memory: mediatek: Add mt8195 smi sub common Yong Wu
2021-08-17 20:12 ` Rob Herring
2021-08-10 8:08 ` [PATCH v3 03/13] memory: mtk-smi: Use clk_bulk clock ops Yong Wu
2021-08-10 8:08 ` [PATCH v3 04/13] memory: mtk-smi: Rename smi_gen to smi_type Yong Wu
2021-08-10 8:08 ` [PATCH v3 05/13] memory: mtk-smi: Adjust some code position Yong Wu
2021-08-10 8:08 ` [PATCH v3 06/13] memory: mtk-smi: Add error handle for smi_probe Yong Wu
2021-08-10 8:08 ` [PATCH v3 07/13] memory: mtk-smi: Add device link for smi-sub-common Yong Wu
2021-08-10 8:08 ` [PATCH v3 08/13] memory: mtk-smi: Add clocks " Yong Wu
2021-08-10 8:08 ` [PATCH v3 09/13] memory: mtk-smi: Use devm_platform_ioremap_resource Yong Wu
2021-08-10 8:08 ` [PATCH v3 10/13] memory: mtk-smi: mt8195: Add smi support Yong Wu
2021-08-10 8:08 ` [PATCH v3 11/13] memory: mtk-smi: mt8195: Add initial setting for smi-common Yong Wu
2021-08-10 8:08 ` [PATCH v3 12/13] memory: mtk-smi: mt8195: Add initial setting for smi-larb Yong Wu
2021-08-10 8:08 ` [PATCH v3 13/13] MAINTAINERS: Add entry for MediaTek SMI Yong Wu
2021-08-18 20:41 ` Krzysztof Kozlowski [this message]
2021-08-19 5:34 ` [PATCH v3 00/13] MT8195 SMI support Yong Wu (吴勇)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a160afd-ceeb-04a3-8213-fe781ec18e30@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=anan.sun@mediatek.com \
--cc=anthony.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=ikjn@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ming-fan.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
--cc=yi.kuo@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).