From: Rob Herring <robh@kernel.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
anan.sun@mediatek.com, ming-fan.chen@mediatek.com,
yi.kuo@mediatek.com, anthony.huang@mediatek.com,
Ikjoon Jang <ikjn@chromium.org>
Subject: Re: [PATCH v3 02/13] dt-bindings: memory: mediatek: Add mt8195 smi sub common
Date: Tue, 17 Aug 2021 15:12:06 -0500 [thread overview]
Message-ID: <YRwYFtVlNjxyRwX+@robh.at.kernel.org> (raw)
In-Reply-To: <20210810080859.29511-3-yong.wu@mediatek.com>
On Tue, Aug 10, 2021 at 04:08:48PM +0800, Yong Wu wrote:
> Add the binding for smi-sub-common. The SMI block diagram like this:
>
> IOMMU
> | |
> smi-common
> ------------------
> | .... |
> larb0 larb7 <-max is 8
>
> The smi-common connects with smi-larb and IOMMU. The maximum larbs number
> that connects with a smi-common is 8. If the engines number is over 8,
> sometimes we use a smi-sub-common which is nearly same with smi-common.
> It supports up to 8 input and 1 output(smi-common has 2 output)
>
> Something like:
>
> IOMMU
> | |
> smi-common
> ---------------------
> | | ...
> larb0 sub-common ... <-max is 8
> -----------
> | | ... <-max is 8 too.
> larb2 larb5
>
> We don't need extra SW setting for smi-sub-common, only the sub-common has
> special clocks need to enable when the engines access dram.
>
> If it is sub-common, it should have a "mediatek,smi" phandle to point to
> its smi-common. meanwhile the sub-common only has one gals clock.
>
> Additionally, add a new property "mediatek,smi_sub_common" for this
> sub-common, this is needed in the IOMMU driver in which we create a device
> link between smi-common and the IOMMU device. If we add the smi-sub-common
> here, the IOMMU driver still need to find the smi-common device. thus,
> add this bool property to indicate if it is sub-common.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> change note:
> a. change mediatek, smi type from phandle-array to phandle from Rob.
> b. Add a new bool property (mediatek,smi_sub_common) to indicate this is
> smi-sub-common. the reason is as above.
> ---
> .../mediatek,smi-common.yaml | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
> index 602592b6c3f5..26bb9903864b 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
> @@ -38,6 +38,7 @@ properties:
> - mediatek,mt8192-smi-common
> - mediatek,mt8195-smi-common-vdo
> - mediatek,mt8195-smi-common-vpp
> + - mediatek,mt8195-smi-sub-common
>
> - description: for mt7623
> items:
> @@ -67,6 +68,14 @@ properties:
> minItems: 2
> maxItems: 4
>
> + mediatek,smi:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: a phandle to the smi-common node above. Only for sub-common.
> +
> + mediatek,smi_sub_common:
s/_/-/
> + type: boolean
> + description: Indicate if this is smi-sub-common.
> +
> required:
> - compatible
> - reg
> @@ -93,6 +102,27 @@ allOf:
> - const: smi
> - const: async
>
> + - if: # only for sub common
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mediatek,mt8195-smi-sub-common
> + then:
> + required:
> + - mediatek,smi
> + - mediatek,smi_sub_common
> + properties:
> + clock:
> + items:
> + minItems: 3
> + maxItems: 3
> + clock-names:
> + items:
> + - const: apb
> + - const: smi
> + - const: gals0
If not allowed for other compatibles, you need:
else:
properties:
mediatek,sni: false
mediatek,smi_sub_common: false
> +
> - if: # for gen2 HW that have gals
> properties:
> compatible:
> --
> 2.18.0
>
>
next prev parent reply other threads:[~2021-08-17 20:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 8:08 [PATCH v3 00/13] MT8195 SMI support Yong Wu
2021-08-10 8:08 ` [PATCH v3 01/13] dt-bindings: memory: mediatek: Add mt8195 smi binding Yong Wu
2021-08-10 8:08 ` [PATCH v3 02/13] dt-bindings: memory: mediatek: Add mt8195 smi sub common Yong Wu
2021-08-17 20:12 ` Rob Herring [this message]
2021-08-10 8:08 ` [PATCH v3 03/13] memory: mtk-smi: Use clk_bulk clock ops Yong Wu
2021-08-10 8:08 ` [PATCH v3 04/13] memory: mtk-smi: Rename smi_gen to smi_type Yong Wu
2021-08-10 8:08 ` [PATCH v3 05/13] memory: mtk-smi: Adjust some code position Yong Wu
2021-08-10 8:08 ` [PATCH v3 06/13] memory: mtk-smi: Add error handle for smi_probe Yong Wu
2021-08-10 8:08 ` [PATCH v3 07/13] memory: mtk-smi: Add device link for smi-sub-common Yong Wu
2021-08-10 8:08 ` [PATCH v3 08/13] memory: mtk-smi: Add clocks " Yong Wu
2021-08-10 8:08 ` [PATCH v3 09/13] memory: mtk-smi: Use devm_platform_ioremap_resource Yong Wu
2021-08-10 8:08 ` [PATCH v3 10/13] memory: mtk-smi: mt8195: Add smi support Yong Wu
2021-08-10 8:08 ` [PATCH v3 11/13] memory: mtk-smi: mt8195: Add initial setting for smi-common Yong Wu
2021-08-10 8:08 ` [PATCH v3 12/13] memory: mtk-smi: mt8195: Add initial setting for smi-larb Yong Wu
2021-08-10 8:08 ` [PATCH v3 13/13] MAINTAINERS: Add entry for MediaTek SMI Yong Wu
2021-08-18 20:41 ` [PATCH v3 00/13] MT8195 SMI support Krzysztof Kozlowski
2021-08-19 5:34 ` Yong Wu (吴勇)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRwYFtVlNjxyRwX+@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=anan.sun@mediatek.com \
--cc=anthony.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=ikjn@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ming-fan.chen@mediatek.com \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
--cc=yi.kuo@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).