From: Keerthy <j-keerthy@ti.com>
To: Colin King <colin.king@canonical.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement
Date: Fri, 28 Jun 2019 08:58:41 +0530 [thread overview]
Message-ID: <1a17ea61-a164-d61f-6416-637d47668f1b@ti.com> (raw)
In-Reply-To: <20190627131639.6394-1-colin.king@canonical.com>
On 27/06/19 6:46 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a
> break statement, causing it to fall through to a dev_err message.
> Fix this by adding in the missing break statement.
>
> Addresses-Coverity: ("Missing break in switch")
> Fixes: 7ee63bd74750 ("regulator: lp87565: Add 4-phase lp87561 regulator support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/regulator/lp87565-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565-regulator.c
> index 993c11702083..5d067f7c2116 100644
> --- a/drivers/regulator/lp87565-regulator.c
> +++ b/drivers/regulator/lp87565-regulator.c
> @@ -180,6 +180,7 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
> case LP87565_DEVICE_TYPE_LP87561_Q1:
> min_idx = LP87565_BUCK_3210;
> max_idx = LP87565_BUCK_3210;
> + break;
Thanks Colin.
Reviewed-by: Keerthy <j-keerthy@ti.com>
> default:
> dev_err(lp87565->dev, "Invalid lp config %d\n",
> lp87565->dev_type);
>
next prev parent reply other threads:[~2019-06-28 3:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 13:16 [PATCH][next] regulator: lp87565: fix missing break in switch statement Colin King
2019-06-28 3:28 ` Keerthy [this message]
2019-06-28 14:36 ` Mark Brown
2019-06-28 21:18 ` Colin Ian King
2019-07-02 10:44 ` Lee Jones
2019-07-02 11:12 ` Colin Ian King
2019-07-02 11:31 ` Lee Jones
2019-07-02 11:36 ` Keerthy
2019-07-02 12:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a17ea61-a164-d61f-6416-637d47668f1b@ti.com \
--to=j-keerthy@ti.com \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).