From: Mark Brown <broonie@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Keerthy <j-keerthy@ti.com>, Liam Girdwood <lgirdwood@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement
Date: Fri, 28 Jun 2019 15:36:28 +0100 [thread overview]
Message-ID: <20190628143628.GJ5379@sirena.org.uk> (raw)
In-Reply-To: <20190627131639.6394-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
On Thu, Jun 27, 2019 at 02:16:39PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a
> break statement, causing it to fall through to a dev_err message.
> Fix this by adding in the missing break statement.
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-28 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 13:16 [PATCH][next] regulator: lp87565: fix missing break in switch statement Colin King
2019-06-28 3:28 ` Keerthy
2019-06-28 14:36 ` Mark Brown [this message]
2019-06-28 21:18 ` Colin Ian King
2019-07-02 10:44 ` Lee Jones
2019-07-02 11:12 ` Colin Ian King
2019-07-02 11:31 ` Lee Jones
2019-07-02 11:36 ` Keerthy
2019-07-02 12:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628143628.GJ5379@sirena.org.uk \
--to=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=j-keerthy@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).