From: Bagas Sanjaya <bagasdotme@gmail.com>
To: David Wang <00107082@163.com>
Cc: linux-kernel@vger.kernel.org, masahiroy@kernel.org
Subject: Re: [PATCH] scripts/package: add back 'version' for builddeb
Date: Wed, 22 Mar 2023 10:35:04 +0700 [thread overview]
Message-ID: <1a2278c5-5398-2e7a-344d-fd5dd9703b10@gmail.com> (raw)
In-Reply-To: <3ee67285.5853.18704c2158c.Coremail.00107082@163.com>
On 3/21/23 22:20, David Wang wrote:
>
>>
>> Again, your patch looks like corrupted (tabs converted to spaces).
>> Please resubmit; this time; generate the patch via git-format-patch(1)
>> and then send the resulting patch with git-send-email(1).
>>
>> Thanks.
>>
> I did use `git format-patch` and `git send-email`, but I did not run scripts/checkpatch.pl.
> Now when I run scripts/checkpatch.pl against the file generated by `git format-patch`, it shows a warning about "Fixes:" tag, and
> I have resend a patch which pass the checks of scripts/checkpatch.pl, hope this time it could be ok.
>
> ```
> $ scripts/checkpatch.pl 0001-scripts-package-add-back-version-for-builddeb.patch
> total: 0 errors, 0 warnings, 7 lines checked
>
> 0001-scripts-package-add-back-version-for-builddeb.patch has no obvious style problems and is ready for submission.
> ```
>
>
> David
OK, but there is already the similar fix submitted at [1]. Please test it.
Thanks anyway.
[1]: https://lore.kernel.org/linux-kbuild/3351f907cfd0b5d8372e858a8ec9065cc2bd91df.1679434718.git.kevin@kevinlocke.name/
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2023-03-22 3:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 11:08 [PATCH] scripts/package: add back 'version' for builddeb David Wang
2023-03-21 13:12 ` Bagas Sanjaya
2023-03-21 15:20 ` David Wang
2023-03-22 3:35 ` Bagas Sanjaya [this message]
2023-03-22 3:37 ` Bagas Sanjaya
2023-03-22 5:12 ` David Wang
2023-03-21 15:13 David Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a2278c5-5398-2e7a-344d-fd5dd9703b10@gmail.com \
--to=bagasdotme@gmail.com \
--cc=00107082@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).