linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: David Wang <00107082@163.com>, linux-kernel@vger.kernel.org
Cc: masahiroy@kernel.org
Subject: Re: [PATCH] scripts/package: add back 'version' for builddeb
Date: Tue, 21 Mar 2023 20:12:36 +0700	[thread overview]
Message-ID: <a05cfc82-a9e9-ea96-aaca-612ff9c14219@gmail.com> (raw)
In-Reply-To: <20230320110819.23668-1-00107082@163.com>

On 3/20/23 18:08, David Wang wrote:
> Fixes: 36862e14e316 (kbuild: deb-pkg: use dh_listpackages to know
> enabled packages)
> The 'version' variable is still needed for building
> debian 'linux-headers' packages, add it back.
> 
> Signed-off-by: David Wang <00107082@163.com>
> ---
>  scripts/package/builddeb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index c5ae57167d7c..5102d0903f9c 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -215,6 +215,7 @@ install_libc_headers () {
>  
>  rm -f debian/files
>  
> +version=$KERNELRELEASE
>  packages_enabled=$(dh_listpackages)
>  
>  for package in ${packages_enabled}

Hi,

Again, your patch looks like corrupted (tabs converted to spaces).
Please resubmit; this time; generate the patch via git-format-patch(1)
and then send the resulting patch with git-send-email(1).

Thanks.

-- 
An old man doll... just what I always wanted! - Clara


  reply	other threads:[~2023-03-21 13:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 11:08 [PATCH] scripts/package: add back 'version' for builddeb David Wang
2023-03-21 13:12 ` Bagas Sanjaya [this message]
2023-03-21 15:20   ` David Wang
2023-03-22  3:35     ` Bagas Sanjaya
2023-03-22  3:37       ` Bagas Sanjaya
2023-03-22  5:12         ` David Wang
2023-03-21 15:13 David Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a05cfc82-a9e9-ea96-aaca-612ff9c14219@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=00107082@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).