linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Roger Quadros" <rogerq@ti.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	grant.likely@linaro.org, robh+dt@kernel.org,
	devicetree@vger.kernel.org, f.fainelli@gmail.com,
	netdev@vger.kernel.org, frowand.list@gmail.com,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	linux-kernel@vger.kernel.org,
	"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [PATCH RFT 1/2] phylib: add device reset GPIO support
Date: Fri, 13 May 2016 23:56:12 +0300	[thread overview]
Message-ID: <1a44a737-2b81-625b-8edf-d1c3dfcdd619@cogentembedded.com> (raw)
In-Reply-To: <20160513204436.GC7600@lunn.ch>

On 05/13/2016 11:44 PM, Andrew Lunn wrote:

>>> Another issue is that on some boards we have one reset line tied to
>>> multiple PHYs.How do we prevent multiple resets being taking place when each of
>>> the PHYs are registered?
>>
>>    My patch just doesn't address this case -- it's about the
>> individual resets only.
>
> This actually needs to be addresses a layer above. What you have is a
> bus reset, not a device reset.

    No.
    There's simply no such thing as a bus reset for the xMII/MDIO busses, 
there's simply no reset signaling on them. Every device has its own reset 
signal and its own timing requirements.

> So the gpio line is associated to the mdio bus, not a PHY.

    No.

> Either your MDIO driver needs to handle the gpio
> line,  or in __mdio_register(),

    __mdiobus_register(), you mean?

> before it starts looking at the
> children.

    It's basically the same thing.
    The MDIO bus reset is a misconception.

>
> 	Andrew

MBR, Sergei

  reply	other threads:[~2016-05-13 20:56 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 22:21 [PATCH RFT 0/2] Teach phylib hard-resetting devices Sergei Shtylyov
2016-04-08 22:22 ` [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov
2016-04-11 19:25   ` Rob Herring
2016-04-11 19:28     ` Sergei Shtylyov
2016-04-11 22:46       ` Rob Herring
2016-04-08 22:25 ` [PATCH RFT 2/2] macb: kill PHY reset code Sergei Shtylyov
2016-04-11  2:28   ` Andrew Lunn
2016-04-11 17:41     ` Sergei Shtylyov
2016-04-11 18:19       ` Andrew Lunn
2016-04-11 18:39         ` Sergei Shtylyov
2016-04-11 18:51           ` Andrew Lunn
2016-04-11 19:01             ` Sergei Shtylyov
2016-04-26 10:24               ` [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Nicolas Ferre
2016-04-26 17:17                 ` David Miller
2016-04-26 18:27                   ` Sergei Shtylyov
2016-04-27  7:15                     ` Nicolas Ferre
2016-04-26 18:25                 ` Sergei Shtylyov
2016-04-12  9:23             ` [PATCH RFT 2/2] macb: kill PHY reset code Nicolas Ferre
2016-04-12  9:22     ` Nicolas Ferre
2016-04-12 13:40       ` Andrew Lunn
2016-04-12 14:45         ` Nicolas Ferre
2016-04-12 13:54       ` Sergei Shtylyov
2016-04-12 14:57         ` Nicolas Ferre
2016-04-28 22:12 ` [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov
2016-05-03 17:03   ` Rob Herring
2016-05-10 18:32   ` Florian Fainelli
2016-05-10 19:11     ` Sergei Shtylyov
2016-05-10 19:13       ` Florian Fainelli
2016-05-12 18:42   ` Uwe Kleine-König
2016-05-12 21:35     ` Sergei Shtylyov
2016-05-13  4:06       ` Andrew Lunn
2016-05-13 21:16         ` Sergei Shtylyov
2016-05-13  7:06       ` Uwe Kleine-König
2016-05-13 21:49         ` Sergei Shtylyov
2016-05-13 19:18       ` Sergei Shtylyov
2016-05-14 21:14         ` Sergei Shtylyov
2016-05-13  9:07     ` Roger Quadros
2016-05-13 19:36       ` Sergei Shtylyov
2016-05-13 20:44         ` Andrew Lunn
2016-05-13 20:56           ` Sergei Shtylyov [this message]
2016-05-13 23:44             ` Andrew Lunn
2016-05-14 19:36               ` Sergei Shtylyov
2016-05-14 19:50                 ` Andrew Lunn
2016-05-14 21:46                   ` Sergei Shtylyov
2016-05-15 15:23                     ` Andrew Lunn
2016-05-19 13:40                       ` Sergei Shtylyov
2016-05-16  8:51         ` Roger Quadros
2016-05-26  9:00     ` Linus Walleij
2016-05-26 19:00       ` Uwe Kleine-König
2016-05-30 14:57         ` Linus Walleij
2020-07-23  7:24 ` Technical Help jollyzula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a44a737-2b81-625b-8edf-d1c3dfcdd619@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=frowand.list@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@ti.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).