linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: nicolas.ferre@atmel.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT 2/2] macb: kill PHY reset code
Date: Mon, 11 Apr 2016 20:19:04 +0200	[thread overview]
Message-ID: <20160411181904.GB29709@lunn.ch> (raw)
In-Reply-To: <570BE1C5.70502@cogentembedded.com>

> >The code you are deleting would of ignored the flags in the gpio
> >property, i.e. active low.
> 
>    Hm, you're right -- I forgot about that... :-/
> 
> >The new code in the previous patch does
> >however take the flags into account. Did you check if there are any
> >device trees which have flags, which were never used, but are now
> >going to be used and thus break...
> 
>    Checked this now and found out arch/arm/boot/dts/ar91-vinco.dts.
> Looks like it needs to be fixed indeed...

And this is where it gets tricky. You are breaking backwards
compatibility by now respecting the flag. An old DT blob is not going
to work.

You potentially need to add a new property and deprecate the old one.

    Andrew

  reply	other threads:[~2016-04-11 18:19 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 22:21 [PATCH RFT 0/2] Teach phylib hard-resetting devices Sergei Shtylyov
2016-04-08 22:22 ` [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov
2016-04-11 19:25   ` Rob Herring
2016-04-11 19:28     ` Sergei Shtylyov
2016-04-11 22:46       ` Rob Herring
2016-04-08 22:25 ` [PATCH RFT 2/2] macb: kill PHY reset code Sergei Shtylyov
2016-04-11  2:28   ` Andrew Lunn
2016-04-11 17:41     ` Sergei Shtylyov
2016-04-11 18:19       ` Andrew Lunn [this message]
2016-04-11 18:39         ` Sergei Shtylyov
2016-04-11 18:51           ` Andrew Lunn
2016-04-11 19:01             ` Sergei Shtylyov
2016-04-26 10:24               ` [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Nicolas Ferre
2016-04-26 17:17                 ` David Miller
2016-04-26 18:27                   ` Sergei Shtylyov
2016-04-27  7:15                     ` Nicolas Ferre
2016-04-26 18:25                 ` Sergei Shtylyov
2016-04-12  9:23             ` [PATCH RFT 2/2] macb: kill PHY reset code Nicolas Ferre
2016-04-12  9:22     ` Nicolas Ferre
2016-04-12 13:40       ` Andrew Lunn
2016-04-12 14:45         ` Nicolas Ferre
2016-04-12 13:54       ` Sergei Shtylyov
2016-04-12 14:57         ` Nicolas Ferre
2016-04-28 22:12 ` [PATCH RFT 1/2] phylib: add device reset GPIO support Sergei Shtylyov
2016-05-03 17:03   ` Rob Herring
2016-05-10 18:32   ` Florian Fainelli
2016-05-10 19:11     ` Sergei Shtylyov
2016-05-10 19:13       ` Florian Fainelli
2016-05-12 18:42   ` Uwe Kleine-König
2016-05-12 21:35     ` Sergei Shtylyov
2016-05-13  4:06       ` Andrew Lunn
2016-05-13 21:16         ` Sergei Shtylyov
2016-05-13  7:06       ` Uwe Kleine-König
2016-05-13 21:49         ` Sergei Shtylyov
2016-05-13 19:18       ` Sergei Shtylyov
2016-05-14 21:14         ` Sergei Shtylyov
2016-05-13  9:07     ` Roger Quadros
2016-05-13 19:36       ` Sergei Shtylyov
2016-05-13 20:44         ` Andrew Lunn
2016-05-13 20:56           ` Sergei Shtylyov
2016-05-13 23:44             ` Andrew Lunn
2016-05-14 19:36               ` Sergei Shtylyov
2016-05-14 19:50                 ` Andrew Lunn
2016-05-14 21:46                   ` Sergei Shtylyov
2016-05-15 15:23                     ` Andrew Lunn
2016-05-19 13:40                       ` Sergei Shtylyov
2016-05-16  8:51         ` Roger Quadros
2016-05-26  9:00     ` Linus Walleij
2016-05-26 19:00       ` Uwe Kleine-König
2016-05-30 14:57         ` Linus Walleij
2020-07-23  7:24 ` Technical Help jollyzula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160411181904.GB29709@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).