From: Ken Goldman <kgold@linux.ibm.com>
To: Eric Biggers <ebiggers@kernel.org>,
Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
zohar@linux.ibm.com, dmitry.kasatkin@gmail.com,
jmorris@namei.org, serge@hallyn.com,
linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] crypto: sm3 - add a new alias name sm3-256
Date: Mon, 10 Feb 2020 11:30:26 -0500 [thread overview]
Message-ID: <1a623251-e83a-3b70-9fbd-8e929a23f7d8@linux.ibm.com> (raw)
In-Reply-To: <20200210031717.GA5198@sol.localdomain>
On 2/9/2020 10:17 PM, Eric Biggers wrote:
> According to https://tools.ietf.org/id/draft-oscca-cfrg-sm3-01.html,
> SM3 always produces a 256-bit hash value. E.g., it says:
>
> "SM3 produces an output hash value of 256 bits long"
>
> and
>
> "SM3 is a hash function that generates a 256-bit hash value."
>
> I don't see any mention of "SM3-256".
>
> So why not just keep it as "sm3" and change hash_info.c instead?
> Since the name there is currently wrong, no one can be using it yet.
Question: Is 256 bits fundamental to SM3? Could there ever be a
variant in the future that's e.g., 512 bits?
next prev parent reply other threads:[~2020-02-10 16:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 9:22 [PATCH] IMA hash algorithm supports sm3-256 Tianjia Zhang
2020-02-07 9:22 ` [PATCH 1/2] crypto: sm3 - add a new alias name sm3-256 Tianjia Zhang
2020-02-10 3:17 ` Eric Biggers
[not found] ` <b7ce247b-ede1-4b01-bb11-894c042679e1.tianjia.zhang@linux.alibaba.com>
2020-02-10 12:06 ` 回复：[PATCH " Tianjia Zhang
2020-02-10 16:30 ` Ken Goldman [this message]
2020-02-10 16:39 ` [PATCH " James Bottomley
[not found] ` <7a496bb15f264eab920bf081338d67af@MN2PR20MB2973.namprd20.prod.outlook.com>
2020-02-10 17:01 ` Van Leeuwen, Pascal
2020-02-10 17:39 ` Mimi Zohar
2020-02-10 18:02 ` Ken Goldman
2020-02-10 18:36 ` Eric Biggers
[not found] ` <3b21122352a44cb9a20030a32f07e38a@MN2PR20MB2973.namprd20.prod.outlook.com>
2020-02-11 7:56 ` Van Leeuwen, Pascal
2020-02-07 9:22 ` [PATCH 2/2] ima: add sm3-256 algorithm to hash algorithm configuration list Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a623251-e83a-3b70-9fbd-8e929a23f7d8@linux.ibm.com \
--to=kgold@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=dmitry.kasatkin@gmail.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).