From: "Stephen Bates" <sbates@raithlin.com>
To: "Jon Derrick" <jonathan.derrick@intel.com>
Cc: axboe@fb.com, sagi@grimberg.me, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
james_p_freyensee@linux.intel.com
Subject: Re: [PATCH 2/2] nvme: improve cmb sysfs reporting
Date: Mon, 9 Jan 2017 13:37:06 -0600 [thread overview]
Message-ID: <1aa7cc9028eab7ebc2a2e9c6bb48e43c.squirrel@webmail.raithlin.com> (raw)
In-Reply-To: <20161219154256.GB3512@localhost.localdomain>
> Minor nit below
>
>
>> +
>> + for (i = NVME_CMB_CAP_SQS; i <= NVME_CMB_CAP_WDS; i++)
>>
> I'd prefer seeing (i = 0; i < ARRAY_SIZE(..); i++) because it provides
> automatic bounds checking against future code.
>
Thanks Jon, I will take a look at doing this in a V1.
Stephen
next prev parent reply other threads:[~2017-01-09 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 18:54 [PATCH 0/2] nvme: Improvements in sysfs entry for NVMe CMBs Stephen Bates
2016-12-16 18:54 ` [PATCH 1/2] nvme : Use correct scnprintf in cmb show Stephen Bates
2016-12-19 15:20 ` Jon Derrick
2016-12-16 18:54 ` [PATCH 2/2] nvme: improve cmb sysfs reporting Stephen Bates
2016-12-19 15:42 ` Jon Derrick
2017-01-09 19:37 ` Stephen Bates [this message]
2016-12-16 19:23 ` [PATCH 0/2] nvme: Improvements in sysfs entry for NVMe CMBs Jens Axboe
2016-12-16 19:37 ` Stephen Bates
2016-12-19 15:36 ` Jens Axboe
2017-01-09 19:35 ` Stephen Bates
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aa7cc9028eab7ebc2a2e9c6bb48e43c.squirrel@webmail.raithlin.com \
--to=sbates@raithlin.com \
--cc=axboe@fb.com \
--cc=james_p_freyensee@linux.intel.com \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).