From: Jens Axboe <axboe@fb.com>
To: Stephen Bates <sbates@raithlin.com>,
<linux-kernel@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
<linux-block@vger.kernel.org>
Cc: <sagi@grimberg.me>, <james_p_freyensee@linux.intel.com>,
<jonathan.derrick@intel.com>
Subject: Re: [PATCH 0/2] nvme: Improvements in sysfs entry for NVMe CMBs
Date: Mon, 19 Dec 2016 08:36:48 -0700 [thread overview]
Message-ID: <aead4ef4-4fbf-10a1-c307-24abbc3fe9d6@fb.com> (raw)
In-Reply-To: <1481914491-21456-1-git-send-email-sbates@raithlin.com>
On 12/16/2016 11:54 AM, Stephen Bates wrote:
> Hi
>
> This series adds some more verbosity to the NVMe CMB sysfs entry.
>
> Jens I based this off v4.9 because for some reason your for-4.10/block
> is missing my original CMB commit (202021c1a63c6)?
>
> Stephen
>
> Stephen Bates (2):
> nvme : Use correct scnprintf in cmb show
> nvme: improve cmb sysfs reporting
>
> drivers/nvme/host/pci.c | 33 ++++++++++++++++++++++++++++++---
> include/linux/nvme.h | 8 ++++++++
> 2 files changed, 38 insertions(+), 3 deletions(-)
I have added 1/2, since that one is a no-brainer. For 2/2, not so sure.
Generally we try to avoid having sysfs file that aren't single value
output. That isn't a super hard rule, but it is preferable.
--
Jens Axboe
next prev parent reply other threads:[~2016-12-19 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 18:54 [PATCH 0/2] nvme: Improvements in sysfs entry for NVMe CMBs Stephen Bates
2016-12-16 18:54 ` [PATCH 1/2] nvme : Use correct scnprintf in cmb show Stephen Bates
2016-12-19 15:20 ` Jon Derrick
2016-12-16 18:54 ` [PATCH 2/2] nvme: improve cmb sysfs reporting Stephen Bates
2016-12-19 15:42 ` Jon Derrick
2017-01-09 19:37 ` Stephen Bates
2016-12-16 19:23 ` [PATCH 0/2] nvme: Improvements in sysfs entry for NVMe CMBs Jens Axboe
2016-12-16 19:37 ` Stephen Bates
2016-12-19 15:36 ` Jens Axboe [this message]
2017-01-09 19:35 ` Stephen Bates
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aead4ef4-4fbf-10a1-c307-24abbc3fe9d6@fb.com \
--to=axboe@fb.com \
--cc=james_p_freyensee@linux.intel.com \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).