* [PATCH] linux/video_{de,en}coder.h: cleanup for userspace
@ 2008-10-26 10:47 Mike Frysinger
2008-10-28 3:31 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2008-10-26 10:47 UTC (permalink / raw)
To: v4l-dvb-maintainer, akpm; +Cc: linux-kernel
Make sure the linux/video_{de,en}coder.h header files include other header
files that they use (for types and structures).
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
include/linux/video_decoder.h | 3 +++
include/linux/video_encoder.h | 2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/include/linux/video_decoder.h b/include/linux/video_decoder.h
index 121e26d..25a191a 100644
--- a/include/linux/video_decoder.h
+++ b/include/linux/video_decoder.h
@@ -1,6 +1,9 @@
#ifndef _LINUX_VIDEO_DECODER_H
#define _LINUX_VIDEO_DECODER_H
+#include <linux/types.h>
+#include <linux/videodev.h>
+
#define HAVE_VIDEO_DECODER 1
struct video_decoder_capability { /* this name is too long */
diff --git a/include/linux/video_encoder.h b/include/linux/video_encoder.h
index 4b0e690..b7b6423 100644
--- a/include/linux/video_encoder.h
+++ b/include/linux/video_encoder.h
@@ -1,6 +1,8 @@
#ifndef _LINUX_VIDEO_ENCODER_H
#define _LINUX_VIDEO_ENCODER_H
+#include <linux/types.h>
+
struct video_encoder_capability { /* this name is too long */
__u32 flags;
#define VIDEO_ENCODER_PAL 1 /* can encode PAL signal */
--
1.6.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] linux/video_{de,en}coder.h: cleanup for userspace
2008-10-26 10:47 [PATCH] linux/video_{de,en}coder.h: cleanup for userspace Mike Frysinger
@ 2008-10-28 3:31 ` Andrew Morton
2008-10-28 3:34 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2008-10-28 3:31 UTC (permalink / raw)
To: Mike Frysinger; +Cc: v4l-dvb-maintainer, linux-kernel
On Sun, 26 Oct 2008 06:47:44 -0400 Mike Frysinger <vapier@gentoo.org> wrote:
> Make sure the linux/video_{de,en}coder.h header files include other header
> files that they use (for types and structures).
>
checkpatch (amazing tool, and it's free!) said:
ERROR: Don't use <linux/videodev.h>: see Documentation/feature-removal-schedule.txt
#23: FILE: include/linux/video_decoder.h:5:
+#include <linux/videodev.h>
so I'll drop this one.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] linux/video_{de,en}coder.h: cleanup for userspace
2008-10-28 3:31 ` Andrew Morton
@ 2008-10-28 3:34 ` Mike Frysinger
0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2008-10-28 3:34 UTC (permalink / raw)
To: Andrew Morton; +Cc: v4l-dvb-maintainer, linux-kernel
On Mon, Oct 27, 2008 at 11:31 PM, Andrew Morton wrote:
> On Sun, 26 Oct 2008 06:47:44 -0400 Mike Frysinger wrote:
>> Make sure the linux/video_{de,en}coder.h header files include other header
>> files that they use (for types and structures).
>
> checkpatch (amazing tool, and it's free!) said:
>
> ERROR: Don't use <linux/videodev.h>: see Documentation/feature-removal-schedule.txt
> #23: FILE: include/linux/video_decoder.h:5:
> +#include <linux/videodev.h>
>
> so I'll drop this one.
maybe, but video_decoder.h def uses things in linux/videodev.h today.
if we add the include, hopefully it'll help people realize they need
to remove the relevant things from video_decoder.h as well.
-mike
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-28 3:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-26 10:47 [PATCH] linux/video_{de,en}coder.h: cleanup for userspace Mike Frysinger
2008-10-28 3:31 ` Andrew Morton
2008-10-28 3:34 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).