From: Akira shimahara <akira215corp@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: zbr@ioremap.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Changes in w1_therm.c and adding w1_therm.h
Date: Sun, 26 Apr 2020 14:36:52 +0200 [thread overview]
Message-ID: <1b002fb8caf1755b89882fd7a3bbac1565959a6d.camel@gmail.com> (raw)
In-Reply-To: <20200426075141.GB2100063@kroah.com>
Le dimanche 26 avril 2020 à 09:51 +0200, Greg KH a écrit :
> On Sat, Apr 25, 2020 at 05:31:41PM +0200, Akira Shimahara wrote:
> > From: Akira SHIMAHARA <akira215corp@gmail.com>
> >
> > Patch for enhacement of w1_therm module. Added features :
> > - Bulk read : send one command for all the slaves
> > on the bus to trigger temperature conversion
> > - Optimized conversion time regarding to device resolution
> > - Dedicated sysfs entry for powering read,
> > resolution set/get, eeprom save/restore
> > - Alarms settings and reading
> > - Code optimization to mitigate bus traffic
> > (devices information are stored to avoid
> > interrogating each device every-time)
> >
> > Following sysfs entry are added :
> > - temperature (RO) : return the temperature in 1/1000°
> > - ext_power (RO) : return the power status of the device
> > - resolution (RW) : get or set the device resolution (supported
> > devices)
> > - eeprom (WO) :trigger a save or restore to/from device EEPROM
> > - alarms (RW) : read or write TH and TL in the device RAM
> > - therm_bulk_read (RW) : Attribute at master level to trigger
> > bulk read and to survey the progress of devices
> > conversions
> > - w1_slave has been kept for compatibility
> >
> > Main motivation was to improve temperature reading speed, which
> > depend
> > on resolution settings of devices. The module store the powwer
> > status and
> > the resolution of each device so that during reading operation, no
> > transaction is required on the bus, which improve speed.
> > The hardware status is checked as soon as a new device is
> > detected,
> > when a user change occurred, or when the corresponding sys file is
> > accessed by user.
> >
> > The bulk read allow to trigger convserion of all devices on the bus
> > at
> > the same time. It will apply a strong pull up on the line if at
> > least
> > one device required it. The duration of the pull up is the max time
> > required by a device on the line.
> >
> > Please let me know any feedback you have on this patch.
> >
> > Thanks ahead,
> >
> > Signed-off-by: Akira Shimahara <akira215corp@gmail.com>
> > ---
> > Changes in v2:
> > - Adding documentation in Documentatin/ABI/testing/sysfs-driver-
> > w1_therm
> > - Updating existing documentation in
> > Documentation/w1/slaves/w1_therm.rst
> >
> > drivers/w1/slaves/w1_therm.c | 1406 ++++++++++++++++++++++++++--
> > ------
> > drivers/w1/slaves/w1_therm.h | 386 ++++++++++
> > 2 files changed, 1470 insertions(+), 322 deletions(-)
> > create mode 100644 drivers/w1/slaves/w1_therm.h
>
> No documentation files are added here :(
>
It's in the PATCH 2/2 included in the previous mail. You want me to
merge in one commit ?. I thought it was easier for you to keep a track
of the v1.
Let me know what you prefer.
Thanks ahead
Akira SHIMAHARA
next prev parent reply other threads:[~2020-04-26 12:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 17:02 [PATCH] Changes in w1_therm.c and adding w1_therm.h Akira Shimahara
2020-04-16 20:12 ` Evgeniy Polyakov
2020-04-17 13:04 ` akira215
2020-04-23 14:41 ` Greg KH
2020-04-23 17:07 ` Evgeniy Polyakov
2020-04-23 17:59 ` Akira shimahara
2020-04-23 18:16 ` Evgeniy Polyakov
2020-04-25 15:31 ` [PATCH v2 1/2] " Akira Shimahara
2020-04-26 7:51 ` Greg KH
2020-04-26 12:36 ` Akira shimahara [this message]
2020-04-26 17:09 ` Greg KH
2020-04-26 17:20 ` Akira shimahara
2020-04-28 12:44 ` Greg KH
2020-04-28 13:42 ` Akira shimahara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b002fb8caf1755b89882fd7a3bbac1565959a6d.camel@gmail.com \
--to=akira215corp@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).