From: Evgeniy Polyakov <zbr@ioremap.net>
To: Akira Shimahara <akira215corp@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Greg Kroah-Hartman <greg@kroah.com>
Subject: Re: [PATCH] Changes in w1_therm.c and adding w1_therm.h
Date: Thu, 16 Apr 2020 23:12:40 +0300 [thread overview]
Message-ID: <20621587067856@mail.yandex.ru> (raw)
In-Reply-To: <20200414170248.299534-1-akira215corp@gmail.com>
Hi
14.04.2020, 20:03, "Akira Shimahara" <akira215corp@gmail.com>:
> From: Akira SHIMAHARA <akira215corp@gmail.com>
>
> Patch for enhacement of w1_therm module. Added features :
> - Bulk read : send one command for all the slaves
> on the bus to trigger temperature conversion
> - Optimized conversion time regarding to device resolution
> - Dedicated sysfs entry for powering read,
> resolution set/get, eeprom save/restore
> - Alarms settings and reading
> - Code optimization to mitigate bus traffic
> (devices information are stored to avoid
> interrogating each device every-time)
>
> Following sysfs entry are added :
> - temperature (RO) : return the temperature in 1/1000°
> - ext_power (RO) : return the power status of the device
> - resolution (RW) : get or set the device resolution (supported devices)
> - eeprom (WO) :trigger a save or restore to/from device EEPROM
> - alarms (RW) : read or write TH and TL in the device RAM
> - therm_bulk_read (RW) : Attribute at master level to trigger
> bulk read and to survey the progress of devices conversions
> - w1_slave has been kept for compatibility
>
> Main motivation was to improve temperature reading speed, which depend
> on resolution settings of devices. The module store the powwer status and
> the resolution of each device so that during reading operation, no
> transaction is required on the bus, which improve speed.
> The harware status is checked as soon as a new device is detected,
> when a user change occured, or when the corresponding sys file is
> accessed by user.
>
> The bulk read allow to trigger convserion of all devices on the bus at
> the same time. It will apply a strong pull up on the line if at least
> one device required it. The duration of the pull up is the max time
> required by a device on the line.
>
> Please let me know any feedback you have on this patch.
>
> Thanks ahead,
>
> Signed-off-by: Akira Shimahara <akira215corp@gmail.com>
Looks good to me, thank you!
These are really good changes.
Greg, please pull it into your tree, thank you.
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
next prev parent reply other threads:[~2020-04-16 20:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 17:02 [PATCH] Changes in w1_therm.c and adding w1_therm.h Akira Shimahara
2020-04-16 20:12 ` Evgeniy Polyakov [this message]
2020-04-17 13:04 ` akira215
2020-04-23 14:41 ` Greg KH
2020-04-23 17:07 ` Evgeniy Polyakov
2020-04-23 17:59 ` Akira shimahara
2020-04-23 18:16 ` Evgeniy Polyakov
2020-04-25 15:31 ` [PATCH v2 1/2] " Akira Shimahara
2020-04-26 7:51 ` Greg KH
2020-04-26 12:36 ` Akira shimahara
2020-04-26 17:09 ` Greg KH
2020-04-26 17:20 ` Akira shimahara
2020-04-28 12:44 ` Greg KH
2020-04-28 13:42 ` Akira shimahara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20621587067856@mail.yandex.ru \
--to=zbr@ioremap.net \
--cc=akira215corp@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).