* [PATCH] dt-bindings: soc: qcom,rpmh-rsc: simplify qcom,tcs-config
@ 2022-04-26 11:07 Krzysztof Kozlowski
2022-04-26 18:17 ` Rob Herring
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-26 11:07 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Rob Herring
The schema for "qcom,tcs-config" property can be a little bit simpler,
without the need of defining each item. Also move the description of
each part of "qcom,tcs-config" tupple to the tupple items description.
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/soc/qcom/qcom,rpmh-rsc.yaml | 33 +++++++------------
1 file changed, 11 insertions(+), 22 deletions(-)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
index f5ecf4a8c377..4a50f1d27724 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
@@ -65,33 +65,22 @@ properties:
qcom,tcs-config:
$ref: /schemas/types.yaml#/definitions/uint32-matrix
+ minItems: 4
+ maxItems: 4
items:
- - items:
- - description: TCS type
- enum: [ 0, 1, 2, 3 ]
- - description: Number of TCS
- - items:
- - description: TCS type
- enum: [ 0, 1, 2, 3 ]
- - description: Number of TCS
- - items:
- - description: TCS type
- enum: [ 0, 1, 2, 3]
- - description: Numbe r of TCS
- - items:
- - description: TCS type
- enum: [ 0, 1, 2, 3 ]
- - description: Number of TCS
+ items:
+ - description: |
+ TCS type::
+ - ACTIVE_TCS
+ - SLEEP_TCS
+ - WAKE_TCS
+ - CONTROL_TCS
+ enum: [ 0, 1, 2, 3 ]
+ - description: Number of TCS
description: |
The tuple defining the configuration of TCS. Must have two cells which
describe each TCS type. The order of the TCS must match the hardware
configuration.
- Cell 1 (TCS Type):: TCS types to be specified::
- - ACTIVE_TCS
- - SLEEP_TCS
- - WAKE_TCS
- - CONTROL_TCS
- Cell 2 (Number of TCS):: <u32>
qcom,tcs-offset:
$ref: /schemas/types.yaml#/definitions/uint32
--
2.32.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom,rpmh-rsc: simplify qcom,tcs-config
2022-04-26 11:07 [PATCH] dt-bindings: soc: qcom,rpmh-rsc: simplify qcom,tcs-config Krzysztof Kozlowski
@ 2022-04-26 18:17 ` Rob Herring
2022-05-20 14:54 ` Krzysztof Kozlowski
2022-06-20 19:41 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-04-26 18:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Andy Gross, Rob Herring, linux-arm-msm,
devicetree, Krzysztof Kozlowski, linux-kernel
On Tue, 26 Apr 2022 13:07:57 +0200, Krzysztof Kozlowski wrote:
> The schema for "qcom,tcs-config" property can be a little bit simpler,
> without the need of defining each item. Also move the description of
> each part of "qcom,tcs-config" tupple to the tupple items description.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/soc/qcom/qcom,rpmh-rsc.yaml | 33 +++++++------------
> 1 file changed, 11 insertions(+), 22 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom,rpmh-rsc: simplify qcom,tcs-config
2022-04-26 11:07 [PATCH] dt-bindings: soc: qcom,rpmh-rsc: simplify qcom,tcs-config Krzysztof Kozlowski
2022-04-26 18:17 ` Rob Herring
@ 2022-05-20 14:54 ` Krzysztof Kozlowski
2022-06-20 18:42 ` Krzysztof Kozlowski
2022-06-20 19:41 ` Krzysztof Kozlowski
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-20 14:54 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel
Cc: Rob Herring
On 26/04/2022 13:07, Krzysztof Kozlowski wrote:
> The schema for "qcom,tcs-config" property can be a little bit simpler,
> without the need of defining each item. Also move the description of
> each part of "qcom,tcs-config" tupple to the tupple items description.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Hi,
This was sent a month ago... any chances for pick up?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom,rpmh-rsc: simplify qcom,tcs-config
2022-05-20 14:54 ` Krzysztof Kozlowski
@ 2022-06-20 18:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-20 18:42 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel
Cc: Rob Herring
On 20/05/2022 16:54, Krzysztof Kozlowski wrote:
> On 26/04/2022 13:07, Krzysztof Kozlowski wrote:
>> The schema for "qcom,tcs-config" property can be a little bit simpler,
>> without the need of defining each item. Also move the description of
>> each part of "qcom,tcs-config" tupple to the tupple items description.
>>
>> Suggested-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Hi,
>
> This was sent a month ago... any chances for pick up?
I sent it on 26 of April, on 20th of May I pinged, so now it is 20th of
June.
OK, I got the point. :) I'll pick it up. Ping me if anyone wants to take
it instead.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom,rpmh-rsc: simplify qcom,tcs-config
2022-04-26 11:07 [PATCH] dt-bindings: soc: qcom,rpmh-rsc: simplify qcom,tcs-config Krzysztof Kozlowski
2022-04-26 18:17 ` Rob Herring
2022-05-20 14:54 ` Krzysztof Kozlowski
@ 2022-06-20 19:41 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-20 19:41 UTC (permalink / raw)
To: linux-kernel, bjorn.andersson, agross, linux-arm-msm, devicetree,
robh+dt, krzysztof.kozlowski+dt, krzysztof.kozlowski
Cc: robh
On Tue, 26 Apr 2022 13:07:57 +0200, Krzysztof Kozlowski wrote:
> The schema for "qcom,tcs-config" property can be a little bit simpler,
> without the need of defining each item. Also move the description of
> each part of "qcom,tcs-config" tupple to the tupple items description.
>
>
Applied, thanks!
[1/1] dt-bindings: soc: qcom,rpmh-rsc: simplify qcom,tcs-config
https://git.kernel.org/krzk/linux-dt/c/d9709fdb20ba6cc252a08743a1a787d1313a09e9
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-20 19:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 11:07 [PATCH] dt-bindings: soc: qcom,rpmh-rsc: simplify qcom,tcs-config Krzysztof Kozlowski
2022-04-26 18:17 ` Rob Herring
2022-05-20 14:54 ` Krzysztof Kozlowski
2022-06-20 18:42 ` Krzysztof Kozlowski
2022-06-20 19:41 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).