From: CASINO_E <CASINO_E@teleline.es>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Merge the changes from siimage 2.4.22-pre9 to 2.6.0-test2
Date: Thu, 07 Aug 2003 11:49:36 +0200 [thread overview]
Message-ID: <1b4bd91b8e12.1b8e121b4bd9@teleline.es> (raw)
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote...
> > if(is_sata(hwif))
> > {
> > + drive->id->hw_config |= 0x6000;
> > if(strstr(drive->id->model, "Maxtor"))
> > return 3;
> > return 4;
> > }
>
> We never check the cable bits for SATA so this is a no-op
Alan,
Without this, in 2.4.22-pre10-ac1, ide_ata66_check() in ide-iops.c
returns 1. This causes, for example, that hdparm -i shows only udma
modes 0 to 2 (although the drive has been set to udma6) and refuses to
set any value above udma2 with an ugly "Speed warnings UDMA 3/4/5 is
not functional".
I do not understand the ide subsystem enough (I should say "at all"),
but maybe there are other implications...
Eduardo.
next reply other threads:[~2003-08-07 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-07 9:49 CASINO_E [this message]
2003-08-07 12:29 ` [PATCH] Merge the changes from siimage 2.4.22-pre9 to 2.6.0-test2 Alan Cox
2003-08-07 13:35 ` Bartlomiej Zolnierkiewicz
2003-08-07 15:53 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2003-07-31 17:49 Marcelo Penna Guerra
2003-07-31 15:25 ` Bartlomiej Zolnierkiewicz
2003-07-31 19:32 ` Marcelo Penna Guerra
2003-07-31 17:19 ` Alan Cox
2003-07-31 17:24 ` Bartlomiej Zolnierkiewicz
2003-08-02 8:29 ` Andre Hedrick
2003-07-31 15:58 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b4bd91b8e12.1b8e121b4bd9@teleline.es \
--to=casino_e@teleline.es \
--cc=casino_e@terra.es \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).