From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>, linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, viresh.kumar@linaro.org,
edubezval@gmail.com, swboyd@chromium.org, dianders@chromium.org,
mka@chromium.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Markus Elfring <elfring@users.sourceforge.net>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 7/9] cpufreq: qoriq: Use auto-registration of thermal cooling device
Date: Mon, 28 Jan 2019 09:37:48 +0100 [thread overview]
Message-ID: <1b5ecceb-f7b4-903b-4158-394618fab8d3@linaro.org> (raw)
In-Reply-To: <f33f279a20f9125ffbec96bfbf1aa9153baebab8.1548654899.git.amit.kucheria@linaro.org>
On 28/01/2019 07:41, Amit Kucheria wrote:
> Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to
> automatically register as a thermal cooling device.
>
> This allows removal of boiler plate code from the driver.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/cpufreq/qoriq-cpufreq.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c
> index 3d773f64b4df..b206e6cb55f0 100644
> --- a/drivers/cpufreq/qoriq-cpufreq.c
> +++ b/drivers/cpufreq/qoriq-cpufreq.c
> @@ -13,7 +13,6 @@
> #include <linux/clk.h>
> #include <linux/clk-provider.h>
> #include <linux/cpufreq.h>
> -#include <linux/cpu_cooling.h>
> #include <linux/errno.h>
> #include <linux/init.h>
> #include <linux/kernel.h>
> @@ -31,7 +30,6 @@
> struct cpu_data {
> struct clk **pclk;
> struct cpufreq_frequency_table *table;
> - struct thermal_cooling_device *cdev;
> };
>
> /*
> @@ -239,7 +237,6 @@ static int qoriq_cpufreq_cpu_exit(struct cpufreq_policy *policy)
> {
> struct cpu_data *data = policy->driver_data;
>
> - cpufreq_cooling_unregister(data->cdev);
> kfree(data->pclk);
> kfree(data->table);
> kfree(data);
> @@ -258,23 +255,15 @@ static int qoriq_cpufreq_target(struct cpufreq_policy *policy,
> return clk_set_parent(policy->clk, parent);
> }
>
> -
> -static void qoriq_cpufreq_ready(struct cpufreq_policy *policy)
> -{
> - struct cpu_data *cpud = policy->driver_data;
> -
> - cpud->cdev = of_cpufreq_cooling_register(policy);
> -}
> -
> static struct cpufreq_driver qoriq_cpufreq_driver = {
> .name = "qoriq_cpufreq",
> - .flags = CPUFREQ_CONST_LOOPS,
> + .flags = CPUFREQ_CONST_LOOPS |
> + CPUFREQ_AUTO_REGISTER_COOLING_DEV,
> .init = qoriq_cpufreq_cpu_init,
> .exit = qoriq_cpufreq_cpu_exit,
> .verify = cpufreq_generic_frequency_table_verify,
> .target_index = qoriq_cpufreq_target,
> .get = cpufreq_generic_get,
> - .ready = qoriq_cpufreq_ready,
> .attr = cpufreq_generic_attr,
> };
>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2019-01-28 8:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 6:41 [PATCH v4 0/9] cpufreq: Add flag to auto-register as cooling device Amit Kucheria
2019-01-28 6:41 ` [PATCH v4 1/9] thermal: cpu_cooling: Require thermal core to be compiled in Amit Kucheria
2019-01-28 6:41 ` [PATCH v4 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked Amit Kucheria
2019-01-28 8:29 ` Daniel Lezcano
2019-01-28 8:32 ` Daniel Lezcano
2019-01-28 12:03 ` Rafael J. Wysocki
2019-01-29 4:21 ` Amit Kucheria
2019-01-28 9:03 ` Rafael J. Wysocki
2019-01-28 6:41 ` [PATCH v4 3/9] cpufreq: qcom-hw: Register as a cpufreq cooling device Amit Kucheria
2019-01-28 8:32 ` Daniel Lezcano
2019-01-28 6:41 ` [PATCH v4 4/9] cpufreq: imx6q: Use auto-registration of thermal " Amit Kucheria
2019-01-28 8:34 ` Daniel Lezcano
2019-01-28 6:41 ` [PATCH v4 5/9] cpufreq: cpufreq-dt: " Amit Kucheria
2019-01-28 8:35 ` Daniel Lezcano
2019-01-28 6:41 ` [PATCH v4 6/9] cpufreq: mediatek: " Amit Kucheria
2019-01-28 8:36 ` Daniel Lezcano
2019-01-28 6:41 ` [PATCH v4 7/9] cpufreq: qoriq: " Amit Kucheria
2019-01-28 8:37 ` Daniel Lezcano [this message]
2019-01-28 6:41 ` [PATCH v4 8/9] cpufreq: scmi: " Amit Kucheria
2019-01-28 8:39 ` Daniel Lezcano
2019-01-28 6:41 ` [PATCH v4 9/9] cpufreq: scpi: " Amit Kucheria
2019-01-28 8:40 ` Daniel Lezcano
2019-01-28 6:47 ` [PATCH v4 0/9] cpufreq: Add flag to auto-register as " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b5ecceb-f7b4-903b-4158-394618fab8d3@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=dianders@chromium.org \
--cc=edubezval@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rjw@rjwysocki.net \
--cc=swboyd@chromium.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).