From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>, linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, viresh.kumar@linaro.org,
edubezval@gmail.com, swboyd@chromium.org, dianders@chromium.org,
mka@chromium.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Tao Wang <kevin.wangtao@hisilicon.com>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked
Date: Mon, 28 Jan 2019 09:32:44 +0100 [thread overview]
Message-ID: <3afd5b04-5caf-053d-48c9-f719eec58da0@linaro.org> (raw)
In-Reply-To: <f6f09e5af6fe78fc27cbdc53a8dc688c6b4124b7.1548654899.git.amit.kucheria@linaro.org>
On 28/01/2019 07:41, Amit Kucheria wrote:
> All cpufreq drivers do similar things to register as a cooling device.
> Provide a cpufreq driver flag so drivers can just ask the cpufreq core
> to register the cooling device on their behalf. This allows us to get
> rid of duplicated code in the drivers.
>
> In order to allow this, we add a struct thermal_cooling_device pointer
> to struct cpufreq_policy so that drivers don't need to store it in a
> private data structure.
>
> Suggested-by: Stephen Boyd <swboyd@chromium.org>
> Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> Tested-by: Matthias Kaehlcke <mka@chromium.org>
> ---
[ ... ]
> +/*
> + * Set by drivers that want the core to automatically register the cpufreq
> + * driver as a thermal cooling device.
> + */
> +#define CPUFREQ_AUTO_REGISTER_COOLING_DEV BIT(7)
> +
Isn't the CPUFREQ_IS_COOLING_DEV more appropriate? We define a property
of the cpufreq driver and the resulting action is to auto-register, no?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2019-01-28 8:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 6:41 [PATCH v4 0/9] cpufreq: Add flag to auto-register as cooling device Amit Kucheria
2019-01-28 6:41 ` [PATCH v4 1/9] thermal: cpu_cooling: Require thermal core to be compiled in Amit Kucheria
2019-01-28 6:41 ` [PATCH v4 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked Amit Kucheria
2019-01-28 8:29 ` Daniel Lezcano
2019-01-28 8:32 ` Daniel Lezcano [this message]
2019-01-28 12:03 ` Rafael J. Wysocki
2019-01-29 4:21 ` Amit Kucheria
2019-01-28 9:03 ` Rafael J. Wysocki
2019-01-28 6:41 ` [PATCH v4 3/9] cpufreq: qcom-hw: Register as a cpufreq cooling device Amit Kucheria
2019-01-28 8:32 ` Daniel Lezcano
2019-01-28 6:41 ` [PATCH v4 4/9] cpufreq: imx6q: Use auto-registration of thermal " Amit Kucheria
2019-01-28 8:34 ` Daniel Lezcano
2019-01-28 6:41 ` [PATCH v4 5/9] cpufreq: cpufreq-dt: " Amit Kucheria
2019-01-28 8:35 ` Daniel Lezcano
2019-01-28 6:41 ` [PATCH v4 6/9] cpufreq: mediatek: " Amit Kucheria
2019-01-28 8:36 ` Daniel Lezcano
2019-01-28 6:41 ` [PATCH v4 7/9] cpufreq: qoriq: " Amit Kucheria
2019-01-28 8:37 ` Daniel Lezcano
2019-01-28 6:41 ` [PATCH v4 8/9] cpufreq: scmi: " Amit Kucheria
2019-01-28 8:39 ` Daniel Lezcano
2019-01-28 6:41 ` [PATCH v4 9/9] cpufreq: scpi: " Amit Kucheria
2019-01-28 8:40 ` Daniel Lezcano
2019-01-28 6:47 ` [PATCH v4 0/9] cpufreq: Add flag to auto-register as " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3afd5b04-5caf-053d-48c9-f719eec58da0@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=dianders@chromium.org \
--cc=edubezval@gmail.com \
--cc=kevin.wangtao@hisilicon.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=swboyd@chromium.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).