From: Heiner Kallweit <hkallweit1@gmail.com>
To: Oleksandr Natalenko <oleksandr@natalenko.name>,
Dave Taht <dave.taht@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Cong Wang" <xiyou.wangcong@gmail.com>,
"Jiří Pírko" <jiri@resnulli.us>,
"Linux Kernel Network Developers" <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: CAKE and r8169 cause panic on upload in v4.19
Date: Sat, 27 Oct 2018 15:43:28 +0200 [thread overview]
Message-ID: <1beabdd3-dbac-de8a-07b0-d0788b1dbc38@gmail.com> (raw)
In-Reply-To: <b80e6819da8ea74f18b6ec0aaf9128fa@natalenko.name>
On 26.10.2018 22:54, Oleksandr Natalenko wrote:
> Hi.
>
> On 26.10.2018 22:25, Dave Taht wrote:
>> Can you repeat your test, disabling gro splitting in cake?
>>
>> the option is "no-split-gso"
>
> Still panics. Takes a couple of rounds, but panics.
>
> Moreover, I've stressed my HTB setup like this too for a longer time, and it panics as well. So, at least, now I have a proof this is not a CAKE-specific thing.
>
> Also, I've stressed it even with noqueue, and the panic is still there. So, this thing is not even sch-specific.
>
> Next, I've seen GRO bits in the call trace and decided to disable GRO on this NIC. So far, I cannot trigger a panic with GRO disabled even after 20 rounds of speedtest.
>
> So, must be some generic thing indeed.
>
In net-next there's the following patch which mentions in the
description that it "eliminates spurious list pointer poisoning":
992cba7e276d ("net: Add and use skb_list_del_init().")
And spurious list pointer poisoning is what we see here (IMO).
As an idea this patch and a8305bff6852 ("net: Add and use skb_mark_not_on_list().")
from net-next could be applied on top of 4.19. Would be curious
whether it fixes the issue.
next prev parent reply other threads:[~2018-10-27 13:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 19:26 CAKE and r8169 cause panic on upload in v4.19 Oleksandr Natalenko
2018-10-26 20:21 ` Heiner Kallweit
2018-10-26 20:25 ` Dave Taht
2018-10-26 20:54 ` Oleksandr Natalenko
2018-10-26 23:08 ` Dave Taht
2018-10-27 11:04 ` Oleksandr Natalenko
2018-10-27 13:43 ` Heiner Kallweit [this message]
2018-10-27 15:37 ` Oleksandr Natalenko
2018-10-28 4:44 ` David Miller
2018-10-28 12:22 ` Oleksandr Natalenko
2018-10-28 17:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1beabdd3-dbac-de8a-07b0-d0788b1dbc38@gmail.com \
--to=hkallweit1@gmail.com \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=toke@toke.dk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).