linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Dave Taht <dave.taht@gmail.com>
Cc: hkallweit1@gmail.com, "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"David S. Miller" <davem@davemloft.net>,
	"Jamal Hadi Salim" <jhs@mojatatu.com>,
	"Cong Wang" <xiyou.wangcong@gmail.com>,
	"Jiří Pírko" <jiri@resnulli.us>,
	"Linux Kernel Network Developers" <netdev@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: CAKE and r8169 cause panic on upload in v4.19
Date: Sat, 27 Oct 2018 13:04:38 +0200	[thread overview]
Message-ID: <5a9ff4ac2596869f23e871b40d862802@natalenko.name> (raw)
In-Reply-To: <CAA93jw4pvEYiXZ-C=yH1H_twZigSYAuEMrE_CCDjzLnVHwAdVA@mail.gmail.com>

Hi.

On 27.10.2018 01:08, Dave Taht wrote:
> Groovy. :whew:
> 
> I do look forward to more cake test results, particularly on different
> network cards such as these, and at speeds higher than 10Gbit on high
> end hardware, and in the 100-1Gbit range on low to mid-range. After
> the last round of features added to cake before it went into linux, we
> run now out of cpu on inbound shaping at those speeds on low end apu2
> (x86) hardware, (atom and a15 chips are not so hot now either) and I
> wish I knew what we could do to speed it up. The new "list skb" and
> mirred code looked promising but we haven't got around to exploring it
> yet.
> 
> Thank you for trying and I hope this gets sorted out on your chipset.

Yeah, but this is still strange. Both LAN computer and router run 4.19, 
but only router panics. The LAN computer employs alx driver, router 
employs r8169. Both had GRO enabled at the moment of panic. But [1] 
reports that this happens with Intel NIC too, so must not be limited to 
Realtek.

> We tend to use flent's rrul test to *really* abuse things. :)
> 
> So cake's ok with gro disabled in hw?

Yes, I've gone back to CAKE but with GRO disabled for NIC, and it is 
stable now. I've also asked a bug reporter [1] to do the same, so we 
will see.

Thanks.

-- 
   Oleksandr Natalenko (post-factum)

[1] https://bugzilla.kernel.org/show_bug.cgi?id=201063

  reply	other threads:[~2018-10-27 11:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26 19:26 CAKE and r8169 cause panic on upload in v4.19 Oleksandr Natalenko
2018-10-26 20:21 ` Heiner Kallweit
2018-10-26 20:25   ` Dave Taht
2018-10-26 20:54     ` Oleksandr Natalenko
2018-10-26 23:08       ` Dave Taht
2018-10-27 11:04         ` Oleksandr Natalenko [this message]
2018-10-27 13:43       ` Heiner Kallweit
2018-10-27 15:37         ` Oleksandr Natalenko
2018-10-28  4:44       ` David Miller
2018-10-28 12:22         ` Oleksandr Natalenko
2018-10-28 17:45           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a9ff4ac2596869f23e871b40d862802@natalenko.name \
    --to=oleksandr@natalenko.name \
    --cc=dave.taht@gmail.com \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=toke@toke.dk \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).