* [PATCH 0/1] Revert patch to fix sound sudden dissapearance @ 2022-12-30 9:30 nickel 2022-12-30 9:30 ` [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" nickel 0 siblings, 1 reply; 4+ messages in thread From: nickel @ 2022-12-30 9:30 UTC (permalink / raw) To: linux-kernel, lgirdwood, regressions Update to 5.10.157 causes sudden sound dissapearance regression for some laptops [PATCH 1/1] Revert "ASoC: soc-pcm: Don't zero TDM masks in ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" 2022-12-30 9:30 [PATCH 0/1] Revert patch to fix sound sudden dissapearance nickel @ 2022-12-30 9:30 ` nickel 2022-12-30 9:53 ` Greg KH 0 siblings, 1 reply; 4+ messages in thread From: nickel @ 2022-12-30 9:30 UTC (permalink / raw) To: linux-kernel; +Cc: Nikolai Kostrigin, Oleg Obidin From: Nikolai Kostrigin <nickel@altlinux.org> This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee. Sudden sound disappearance was reported for some laptops, e.g. Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz lspci 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20) Subsystem: Acer Incorporated [ALI] Device 148c Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12 Memory at 601f270000 (64-bit, non-prefetchable) [size=16K] Memory at 601f000000 (64-bit, non-prefetchable) [size=1M] Capabilities: [50] Power Management version 3 Capabilities: [80] Vendor Specific Information: Len=14 <?> Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+ Kernel driver in use: sof-audio-pci Bisection revealed the commit being reverted. Reported-by: Oleg Obidin <obidinog@basealt.ru> Link: https://bugzilla.altlinux.org/44690 Link: https://bugzilla.kernel.org/show_bug.cgi?id=216861 Signed-off-by: Nikolai Kostrigin <nickel@altlinux.org> --- sound/soc/soc-pcm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 0e2261ee07b67..8b8a9aca2912f 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -723,6 +723,11 @@ static int soc_pcm_open(struct snd_pcm_substream *substream) ret = snd_soc_dai_startup(dai, substream); if (ret < 0) goto err; + + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) + dai->tx_mask = 0; + else + dai->rx_mask = 0; } /* Dynamic PCM DAI links compat checks use dynamic capabilities */ -- 2.33.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" 2022-12-30 9:30 ` [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" nickel @ 2022-12-30 9:53 ` Greg KH 2022-12-30 10:00 ` Thorsten Leemhuis 0 siblings, 1 reply; 4+ messages in thread From: Greg KH @ 2022-12-30 9:53 UTC (permalink / raw) To: nickel; +Cc: linux-kernel, Oleg Obidin On Fri, Dec 30, 2022 at 12:30:53PM +0300, nickel@altlinux.org wrote: > From: Nikolai Kostrigin <nickel@altlinux.org> > > This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee. > > Sudden sound disappearance was reported for some laptops, e.g. > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz > > lspci > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20) > Subsystem: Acer Incorporated [ALI] Device 148c > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12 > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K] > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M] > Capabilities: [50] Power Management version 3 > Capabilities: [80] Vendor Specific Information: Len=14 <?> > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+ > Kernel driver in use: sof-audio-pci > > Bisection revealed the commit being reverted. > > Reported-by: Oleg Obidin <obidinog@basealt.ru> > Link: https://bugzilla.altlinux.org/44690 > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216861 > Signed-off-by: Nikolai Kostrigin <nickel@altlinux.org> > --- > sound/soc/soc-pcm.c | 5 +++++ > 1 file changed, 5 insertions(+) <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. </formletter> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" 2022-12-30 9:53 ` Greg KH @ 2022-12-30 10:00 ` Thorsten Leemhuis 0 siblings, 0 replies; 4+ messages in thread From: Thorsten Leemhuis @ 2022-12-30 10:00 UTC (permalink / raw) To: nickel; +Cc: linux-kernel, Oleg Obidin, Greg KH On 30.12.22 10:53, Greg KH wrote: > On Fri, Dec 30, 2022 at 12:30:53PM +0300, nickel@altlinux.org wrote: >> From: Nikolai Kostrigin <nickel@altlinux.org> >> >> This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee. >> >> Sudden sound disappearance was reported for some laptops, e.g. >> Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz >> >> lspci >> 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20) >> Subsystem: Acer Incorporated [ALI] Device 148c >> Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12 >> Memory at 601f270000 (64-bit, non-prefetchable) [size=16K] >> Memory at 601f000000 (64-bit, non-prefetchable) [size=1M] >> Capabilities: [50] Power Management version 3 >> Capabilities: [80] Vendor Specific Information: Len=14 <?> >> Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+ >> Kernel driver in use: sof-audio-pci >> >> Bisection revealed the commit being reverted. >> >> Reported-by: Oleg Obidin <obidinog@basealt.ru> >> Link: https://bugzilla.altlinux.org/44690 >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216861 >> Signed-off-by: Nikolai Kostrigin <nickel@altlinux.org> >> --- >> sound/soc/soc-pcm.c | 5 +++++ >> 1 file changed, 5 insertions(+) > > <formletter> > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > for how to do this properly. > > </formletter> Also FWIW & FYI: I earlier today brought the regression in question to the attention of the people that are responsible to fix this issue: https://lore.kernel.org/all/bebd692d-7d21-6648-6b7a-c91063bb51c2@leemhuis.info/ With a bit of luck they will soon look into this and fix it, but given the time of year it might take a day or two longer than usual... Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-30 10:01 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-12-30 9:30 [PATCH 0/1] Revert patch to fix sound sudden dissapearance nickel 2022-12-30 9:30 ` [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" nickel 2022-12-30 9:53 ` Greg KH 2022-12-30 10:00 ` Thorsten Leemhuis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).