* [PATCH] block, mm: remove unnecessary __GFP_HIGH flag
@ 2018-07-03 17:14 Shakeel Butt
2018-07-06 13:49 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Shakeel Butt @ 2018-07-03 17:14 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel, Shakeel Butt
The flag GFP_ATOMIC already contains __GFP_HIGH. There is no need to
explicitly or __GFP_HIGH again. So, just remove unnecessary __GFP_HIGH.
Signed-off-by: Shakeel Butt <shakeelb@google.com>
---
block/blk-ioc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-ioc.c b/block/blk-ioc.c
index f23311e4b201..01580f88fcb3 100644
--- a/block/blk-ioc.c
+++ b/block/blk-ioc.c
@@ -278,7 +278,7 @@ int create_task_io_context(struct task_struct *task, gfp_t gfp_flags, int node)
atomic_set(&ioc->nr_tasks, 1);
atomic_set(&ioc->active_ref, 1);
spin_lock_init(&ioc->lock);
- INIT_RADIX_TREE(&ioc->icq_tree, GFP_ATOMIC | __GFP_HIGH);
+ INIT_RADIX_TREE(&ioc->icq_tree, GFP_ATOMIC);
INIT_HLIST_HEAD(&ioc->icq_list);
INIT_WORK(&ioc->release_work, ioc_release_fn);
--
2.18.0.399.gad0ab374a1-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block, mm: remove unnecessary __GFP_HIGH flag
2018-07-03 17:14 [PATCH] block, mm: remove unnecessary __GFP_HIGH flag Shakeel Butt
@ 2018-07-06 13:49 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2018-07-06 13:49 UTC (permalink / raw)
To: Shakeel Butt; +Cc: linux-kernel
On 7/3/18 11:14 AM, Shakeel Butt wrote:
> The flag GFP_ATOMIC already contains __GFP_HIGH. There is no need to
> explicitly or __GFP_HIGH again. So, just remove unnecessary __GFP_HIGH.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-06 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-03 17:14 [PATCH] block, mm: remove unnecessary __GFP_HIGH flag Shakeel Butt
2018-07-06 13:49 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).