* [PATCH] mtip32xx: Fix an error handling path in 'mtip_pci_probe()'
@ 2018-05-10 7:27 Christophe JAILLET
2018-05-10 14:21 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2018-05-10 7:27 UTC (permalink / raw)
To: axboe, ming.lei, martin.petersen, sagi, chris.gekas, bart.vanassche
Cc: linux-block, linux-kernel, kernel-janitors, Christophe JAILLET
Branch to the right label in the error handling path in order to keep it
logical.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/block/mtip32xx/mtip32xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 769c551e3d71..06257b872a7d 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -4273,7 +4273,7 @@ static int mtip_pci_probe(struct pci_dev *pdev,
if (!dd->isr_workq) {
dev_warn(&pdev->dev, "Can't create wq %d\n", dd->instance);
rv = -ENOMEM;
- goto block_initialize_err;
+ goto setmask_err;
}
memset(cpu_list, 0, sizeof(cpu_list));
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtip32xx: Fix an error handling path in 'mtip_pci_probe()'
2018-05-10 7:27 [PATCH] mtip32xx: Fix an error handling path in 'mtip_pci_probe()' Christophe JAILLET
@ 2018-05-10 14:21 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2018-05-10 14:21 UTC (permalink / raw)
To: Christophe JAILLET, ming.lei, martin.petersen, sagi, chris.gekas,
bart.vanassche
Cc: linux-block, linux-kernel, kernel-janitors
On 5/10/18 1:27 AM, Christophe JAILLET wrote:
> Branch to the right label in the error handling path in order to keep it
> logical.
Looks good, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-10 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-10 7:27 [PATCH] mtip32xx: Fix an error handling path in 'mtip_pci_probe()' Christophe JAILLET
2018-05-10 14:21 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).