* [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX
@ 2023-01-15 21:35 Pierluigi Passaro
2023-01-16 19:26 ` Fabio Estevam
2023-01-26 1:08 ` Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Pierluigi Passaro @ 2023-01-15 21:35 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, marex, peng.fan, marcel.ziswiler,
devicetree, linux-arm-kernel, linux-kernel
Cc: eran.m, nate.d, pierluigi.p, pierluigi.passaro
According section
8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
of
i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
the required setting for this specific pin configuration is "1"
Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
---
arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h b/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h
index 83c8f715cd90..b1f11098d248 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h
+++ b/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h
@@ -602,7 +602,7 @@
#define MX8MM_IOMUXC_UART1_RXD_GPIO5_IO22 0x234 0x49C 0x000 0x5 0x0
#define MX8MM_IOMUXC_UART1_RXD_TPSMP_HDATA24 0x234 0x49C 0x000 0x7 0x0
#define MX8MM_IOMUXC_UART1_TXD_UART1_DCE_TX 0x238 0x4A0 0x000 0x0 0x0
-#define MX8MM_IOMUXC_UART1_TXD_UART1_DTE_RX 0x238 0x4A0 0x4F4 0x0 0x0
+#define MX8MM_IOMUXC_UART1_TXD_UART1_DTE_RX 0x238 0x4A0 0x4F4 0x0 0x1
#define MX8MM_IOMUXC_UART1_TXD_ECSPI3_MOSI 0x238 0x4A0 0x000 0x1 0x0
#define MX8MM_IOMUXC_UART1_TXD_GPIO5_IO23 0x238 0x4A0 0x000 0x5 0x0
#define MX8MM_IOMUXC_UART1_TXD_TPSMP_HDATA25 0x238 0x4A0 0x000 0x7 0x0
--
2.37.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX
2023-01-15 21:35 [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX Pierluigi Passaro
@ 2023-01-16 19:26 ` Fabio Estevam
2023-01-21 0:37 ` Pierluigi Passaro
2023-01-26 1:08 ` Shawn Guo
1 sibling, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2023-01-16 19:26 UTC (permalink / raw)
To: Pierluigi Passaro
Cc: robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer, kernel,
linux-imx, marex, peng.fan, marcel.ziswiler, devicetree,
linux-arm-kernel, linux-kernel, eran.m, nate.d,
pierluigi.passaro
On Sun, Jan 15, 2023 at 6:35 PM Pierluigi Passaro
<pierluigi.p@variscite.com> wrote:
>
> According section
> 8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
> of
> i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
> the required setting for this specific pin configuration is "1"
>
> Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm")
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX
2023-01-16 19:26 ` Fabio Estevam
@ 2023-01-21 0:37 ` Pierluigi Passaro
2023-01-23 15:58 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Pierluigi Passaro @ 2023-01-21 0:37 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer, kernel,
linux-imx, marex, peng.fan, marcel.ziswiler, devicetree,
linux-arm-kernel, linux-kernel, Eran Matityahu, Nate Drude,
pierluigi.passaro
On Mon, Jan 16, 2023 at 8:26 PM Fabio Estevam <festevam@gmail.com> wrote:
> On Sun, Jan 15, 2023 at 6:35 PM Pierluigi Passaro
> <pierluigi.p@variscite.com> wrote:
> >
> > According section
> > 8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
> > of
> > i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
> > the required setting for this specific pin configuration is "1"
> >
> > Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
>
> Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm")
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
Thanks for reviewing.
Is there any further action required on my side ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX
2023-01-21 0:37 ` Pierluigi Passaro
@ 2023-01-23 15:58 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2023-01-23 15:58 UTC (permalink / raw)
To: Pierluigi Passaro, Fabio Estevam
Cc: robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer, kernel,
linux-imx, peng.fan, marcel.ziswiler, devicetree,
linux-arm-kernel, linux-kernel, Eran Matityahu, Nate Drude,
pierluigi.passaro
On 1/21/23 01:37, Pierluigi Passaro wrote:
> On Mon, Jan 16, 2023 at 8:26 PM Fabio Estevam <festevam@gmail.com> wrote:
>> On Sun, Jan 15, 2023 at 6:35 PM Pierluigi Passaro
>> <pierluigi.p@variscite.com> wrote:
>>>
>>> According section
>>> 8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
>>> of
>>> i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
>>> the required setting for this specific pin configuration is "1"
>>>
>>> Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
>>
>> Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm")
>>
>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>>
> Thanks for reviewing.
> Is there any further action required on my side ?
Wait for Shawn to review/pick the patch , that's all.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX
2023-01-15 21:35 [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX Pierluigi Passaro
2023-01-16 19:26 ` Fabio Estevam
@ 2023-01-26 1:08 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2023-01-26 1:08 UTC (permalink / raw)
To: Pierluigi Passaro
Cc: robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel, festevam,
linux-imx, marex, peng.fan, marcel.ziswiler, devicetree,
linux-arm-kernel, linux-kernel, eran.m, nate.d,
pierluigi.passaro
On Sun, Jan 15, 2023 at 10:35:03PM +0100, Pierluigi Passaro wrote:
> According section
> 8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
> of
> i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
> the required setting for this specific pin configuration is "1"
>
> Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-26 1:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-15 21:35 [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX Pierluigi Passaro
2023-01-16 19:26 ` Fabio Estevam
2023-01-21 0:37 ` Pierluigi Passaro
2023-01-23 15:58 ` Marek Vasut
2023-01-26 1:08 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).