From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
lorenzo.pieralisi@arm.com, robin.murphy@arm.com
Cc: mark.rutland@arm.com, vkilari@codeaurora.org,
neil.m.leeder@gmail.com, pabba@codeaurora.org,
john.garry@huawei.com, will.deacon@arm.com,
rruigrok@codeaurora.org, linuxarm@huawei.com,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
guohanjun@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] perf: add arm64 smmuv3 pmu driver
Date: Tue, 2 Oct 2018 17:19:03 +0100 [thread overview]
Message-ID: <1dc554eb-7ed2-45b3-109f-8cec286b4525@arm.com> (raw)
In-Reply-To: <ecc2877c-146c-d70f-efd7-306fe704d55f@arm.com>
On 02/10/2018 15:11, Jean-Philippe Brucker wrote:
>> + cfgr = readl_relaxed(smmu_pmu->reg_base + SMMU_PMCG_CFGR);
Something I missed previously: when SMMU_PMCG_CFGR.SID_FILTER_TYPE is 1,
filtering for all counters is configured by SMMU_PMCG_SMR0 and
SMMU_PMCG_EVTYPER0 (instead of having one separate filter per counter).
In that mode with your patch, if the user applies a filter to the first
event in the list passed to perf, it will be applied to all events.
Filter applied on any subsequent event will be ignored. Could we make
this more explicit? Maybe in the probe print that the PMCG is
global-filtering, and when attempting to apply a filter to something
else than EVCNTR0, return an error?
Thanks,
Jean
next prev parent reply other threads:[~2018-10-02 16:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 15:08 [PATCH v3 0/3] arm64 SMMUv3 PMU driver with IORT support Shameer Kolothum
2018-09-21 15:08 ` [PATCH v3 1/3] acpi: arm64: add iort support for PMCG Shameer Kolothum
2018-10-04 16:43 ` Lorenzo Pieralisi
2018-10-04 17:35 ` Robin Murphy
2018-10-05 11:06 ` Shameerali Kolothum Thodi
2018-09-21 15:08 ` [PATCH v3 2/3] perf: add arm64 smmuv3 pmu driver Shameer Kolothum
2018-10-02 14:11 ` Jean-Philippe Brucker
2018-10-02 16:19 ` Jean-Philippe Brucker [this message]
2018-10-02 16:35 ` Robin Murphy
2018-10-03 8:52 ` Shameerali Kolothum Thodi
2018-10-03 8:46 ` Shameerali Kolothum Thodi
2018-10-03 9:46 ` Jean-Philippe Brucker
2018-10-03 10:21 ` Robin Murphy
2018-10-03 10:37 ` Robin Murphy
2018-10-03 11:28 ` Shameerali Kolothum Thodi
2018-10-03 11:06 ` John Garry
2018-10-11 11:25 ` Robin Murphy
2018-10-11 11:49 ` Shameerali Kolothum Thodi
2018-09-21 15:08 ` [PATCH v3 3/3] perf/smmuv3: Add MSI irq support Shameer Kolothum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dc554eb-7ed2-45b3-109f-8cec286b4525@arm.com \
--to=jean-philippe.brucker@arm.com \
--cc=guohanjun@huawei.com \
--cc=john.garry@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=neil.m.leeder@gmail.com \
--cc=pabba@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=rruigrok@codeaurora.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=vkilari@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).