[PATCH] ata: pata_macio: add of_node_put()

[PATCH] ata: pata_macio: add of_node_put()

[Yangtao Li]

of_find_node_by_path() acquires a reference to the node
returned by it and that reference needs to be dropped by its caller.
bl_idle_init() doesn't do that, so fix it.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 drivers/ata/pata_macio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index 9588e685d994..8cc9c429ad95 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port *ap)
 		struct device_node *root = of_find_node_by_path("/");
 		const char *model = of_get_property(root, "model", NULL);
 
+		of_node_put(root);
+
 		if (cable && !strncmp(cable, "80-", 3)) {
 			/* Some drives fail to detect 80c cable in PowerBook
 			 * These machine use proprietary short IDE cable
-- 
2.17.0

Re: [PATCH] ata: pata_macio: add of_node_put()

[Sergei Shtylyov]

Hello!

On 11/21/2018 04:04 PM, Yangtao Li wrote:

> of_find_node_by_path() acquires a reference to the node
> returned by it and that reference needs to be dropped by its caller.
> bl_idle_init() doesn't do that, so fix it.

   I thought we're inside pata_macio_cable_detect()?

> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
>  drivers/ata/pata_macio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> index 9588e685d994..8cc9c429ad95 100644
> --- a/drivers/ata/pata_macio.c
> +++ b/drivers/ata/pata_macio.c
> @@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port *ap)
>  		struct device_node *root = of_find_node_by_path("/");
>  		const char *model = of_get_property(root, "model", NULL);
>  
> +		of_node_put(root);
> +
>  		if (cable && !strncmp(cable, "80-", 3)) {
>  			/* Some drives fail to detect 80c cable in PowerBook
>  			 * These machine use proprietary short IDE cable

MBR, Sergei

Re: [PATCH] ata: pata_macio: add of_node_put()

[Frank Lee]

On Wed, Nov 21, 2018 at 11:24 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>
> Hello!
>
> On 11/21/2018 04:04 PM, Yangtao Li wrote:
>
> > of_find_node_by_path() acquires a reference to the node
> > returned by it and that reference needs to be dropped by its caller.
> > bl_idle_init() doesn't do that, so fix it.
>
>    I thought we're inside pata_macio_cable_detect()?
Hi Sergei：

What do you mean?
Why not release the refcount of root?

Yours,
    Yangtao
>
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> >  drivers/ata/pata_macio.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> > index 9588e685d994..8cc9c429ad95 100644
> > --- a/drivers/ata/pata_macio.c
> > +++ b/drivers/ata/pata_macio.c
> > @@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port *ap)
> >               struct device_node *root = of_find_node_by_path("/");
> >               const char *model = of_get_property(root, "model", NULL);
> >
> > +             of_node_put(root);
> > +
> >               if (cable && !strncmp(cable, "80-", 3)) {
> >                       /* Some drives fail to detect 80c cable in PowerBook
> >                        * These machine use proprietary short IDE cable
>
> MBR, Sergei

Re: [PATCH] ata: pata_macio: add of_node_put()

[Frank Lee]

On Wed, Nov 21, 2018 at 11:31 PM Frank Lee <tiny.windzz@gmail.com> wrote:
>
> On Wed, Nov 21, 2018 at 11:24 PM Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> >
> > Hello!
> >
> > On 11/21/2018 04:04 PM, Yangtao Li wrote:
> >
> > > of_find_node_by_path() acquires a reference to the node
> > > returned by it and that reference needs to be dropped by its caller.
> > > bl_idle_init() doesn't do that, so fix it.
> >
> >    I thought we're inside pata_macio_cable_detect()?
Hi Sergei：

Yeah,this is a typo.
Need me to resend a patch?

Thanks，
Yangtao
> Hi Sergei：
>
> What do you mean?
> Why not release the refcount of root?
>
> Yours,
>     Yangtao
> >
> > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > ---
> > >  drivers/ata/pata_macio.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> > > index 9588e685d994..8cc9c429ad95 100644
> > > --- a/drivers/ata/pata_macio.c
> > > +++ b/drivers/ata/pata_macio.c
> > > @@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port *ap)
> > >               struct device_node *root = of_find_node_by_path("/");
> > >               const char *model = of_get_property(root, "model", NULL);
> > >
> > > +             of_node_put(root);
> > > +
> > >               if (cable && !strncmp(cable, "80-", 3)) {
> > >                       /* Some drives fail to detect 80c cable in PowerBook
> > >                        * These machine use proprietary short IDE cable
> >
> > MBR, Sergei

Re: [PATCH] ata: pata_macio: add of_node_put()

[Sergei Shtylyov]

On 21.11.2018 18:33, Frank Lee wrote:

>>>> of_find_node_by_path() acquires a reference to the node
>>>> returned by it and that reference needs to be dropped by its caller.
>>>> bl_idle_init() doesn't do that, so fix it.
>>>
>>>     I thought we're inside pata_macio_cable_detect()?
> Hi Sergei：
> 
> Yeah,this is a typo.
> Need me to resend a patch?

    This is more of a question for the libata maintainers (but I would resend).

> Thanks，
> Yangtao

MBR, Sergei

Re: [PATCH] ata: pata_macio: add of_node_put()

[Bartlomiej Zolnierkiewicz]

On 11/21/2018 02:04 PM, Yangtao Li wrote:
> of_find_node_by_path() acquires a reference to the node
> returned by it and that reference needs to be dropped by its caller.
> bl_idle_init() doesn't do that, so fix it.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

>  drivers/ata/pata_macio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> index 9588e685d994..8cc9c429ad95 100644
> --- a/drivers/ata/pata_macio.c
> +++ b/drivers/ata/pata_macio.c
> @@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port *ap)
>  		struct device_node *root = of_find_node_by_path("/");
>  		const char *model = of_get_property(root, "model", NULL);
>  
> +		of_node_put(root);
> +
>  		if (cable && !strncmp(cable, "80-", 3)) {
>  			/* Some drives fail to detect 80c cable in PowerBook
>  			 * These machine use proprietary short IDE cable
> 

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Re: [PATCH] ata: pata_macio: add of_node_put()

[Jens Axboe]

On 12/20/18 10:03 AM, Bartlomiej Zolnierkiewicz wrote:
> 
> On 11/21/2018 02:04 PM, Yangtao Li wrote:
>> of_find_node_by_path() acquires a reference to the node
>> returned by it and that reference needs to be dropped by its caller.
>> bl_idle_init() doesn't do that, so fix it.
>>
>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> 
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Yangtao, were you going to resend this one?

-- 
Jens Axboe

Re: [PATCH] ata: pata_macio: add of_node_put()

[Frank Lee]

On Fri, Dec 21, 2018 at 2:01 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 12/20/18 10:03 AM, Bartlomiej Zolnierkiewicz wrote:
> >
> > On 11/21/2018 02:04 PM, Yangtao Li wrote:
> >> of_find_node_by_path() acquires a reference to the node
> >> returned by it and that reference needs to be dropped by its caller.
> >> bl_idle_init() doesn't do that, so fix it.
> >>
> >> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> >
> > Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> Yangtao, were you going to resend this one?
Actually,I've rensent the v2 at  Nov 22.And  I just changed the changelog.
Can you pick it up?

Thanks,
Yangtao

Re: [PATCH] ata: pata_macio: add of_node_put()

[Jens Axboe]

On 12/20/18 6:09 PM, Frank Lee wrote:
> On Fri, Dec 21, 2018 at 2:01 AM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 12/20/18 10:03 AM, Bartlomiej Zolnierkiewicz wrote:
>>>
>>> On 11/21/2018 02:04 PM, Yangtao Li wrote:
>>>> of_find_node_by_path() acquires a reference to the node
>>>> returned by it and that reference needs to be dropped by its caller.
>>>> bl_idle_init() doesn't do that, so fix it.
>>>>
>>>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>>>
>>> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>
>> Yangtao, were you going to resend this one?
> Actually,I've rensent the v2 at  Nov 22.And  I just changed the changelog.
> Can you pick it up?

I missed that, sorry. I'll pick it up.

-- 
Jens Axboe