From: "Reddy, V sujith kumar" <vsujithkumar.reddy@amd.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
broonie@kernel.org, alsa-devel@alsa-project.org
Cc: Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, ajitkumar.pandey@amd.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kai Vehmanen <kai.vehmanen@intel.com>,
Jia-Ju Bai <baijiaju1990@gmail.com>,
Akihiko Odaki <akihiko.odaki@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] ASoC: amd: acp: Add support for rt5682s and rt1019 card with hs instance
Date: Tue, 31 May 2022 14:54:06 +0530 [thread overview]
Message-ID: <1e16d1f5-b466-2f4c-561f-aecf21e35458@amd.com> (raw)
In-Reply-To: <01acfbad-7668-dfc6-b797-a9fa5f402a26@linux.intel.com>
On 5/26/2022 2:58 AM, Pierre-Louis Bossart wrote:
> [CAUTION: External Email]
>
> On 5/25/22 15:34, V sujith kumar Reddy wrote:
>> We have new platform with rt5682s as a primary codec and rt1019 as an
>> amp codec. Add machine struct to register sof audio based sound card
>> on such Chrome machine.
>>
>> Here we are configuring as a soc mclk master and codec slave.
>>
>> Signed-off-by: V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>
>> ---
>> sound/soc/amd/acp-config.c | 9 ++++
>> sound/soc/amd/acp/acp-mach-common.c | 69 ++++++++++++++++++++++++-----
>> sound/soc/amd/acp/acp-sof-mach.c | 15 +++++++
>> 3 files changed, 82 insertions(+), 11 deletions(-)
>>
>> diff --git a/sound/soc/amd/acp-config.c b/sound/soc/amd/acp-config.c
>> index ba9e0adacc4a..39ca48be7be9 100644
>> --- a/sound/soc/amd/acp-config.c
>> +++ b/sound/soc/amd/acp-config.c
>> @@ -147,6 +147,15 @@ struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_sof_machines[] = {
>> .fw_filename = "sof-rmb.ri",
>> .sof_tplg_filename = "sof-acp-rmb.tplg",
>> },
>> + {
>> + .id = "RTL5682",
>> + .drv_name = "rt5682s-hs-rt1019",
>> + .pdata = &acp_quirk_data,
>> + .machine_quirk = snd_soc_acpi_codec_list,
>> + .quirk_data = &_rt1019,
>> + .fw_filename = "sof-rmb.ri",
>> + .sof_tplg_filename = "sof-acp-rmb.tplg",
>> + },
> that means a 3rd entry with the same pair of firmware/topology files?
will change and push new patchset
>
>> {},
>> };
>> EXPORT_SYMBOL(snd_soc_acpi_amd_rmb_sof_machines);
>> diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c
>> index a03b396d96bb..4aad3fee51cf 100644
>> --- a/sound/soc/amd/acp/acp-mach-common.c
>> +++ b/sound/soc/amd/acp/acp-mach-common.c
>> @@ -148,10 +148,15 @@ static int acp_card_hs_startup(struct snd_pcm_substream *substream)
>> struct snd_soc_card *card = rtd->card;
>> struct acp_card_drvdata *drvdata = card->drvdata;
>> struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
>> - int ret;
>> + unsigned int fmt = 0;
> fmt initialization is overridden below.
will change and push new patchset
>
>> + int ret = 0;
> useless init...
will change and push new patchset
>
>> - ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
>> - | SND_SOC_DAIFMT_CBP_CFP);
>> + if (drvdata->soc_mclk)
>> + fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC;
>> + else
>> + fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBP_CFP;
>> +
>> + ret = snd_soc_dai_set_fmt(codec_dai, fmt);
> ... overridden here
will change and push new patchset
>
>> if (ret < 0) {
>> dev_err(rtd->card->dev, "Failed to set dai fmt: %d\n", ret);
>> return ret;
prev parent reply other threads:[~2022-05-31 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220525203415.2227914-1-Vsujithkumar.Reddy@amd.com>
2022-05-25 20:34 ` [PATCH v4 1/2] ASoC: amd: acp: Add support for nau8825 and max98360 card V sujith kumar Reddy
2022-05-25 21:25 ` Pierre-Louis Bossart
2022-05-25 20:34 ` [PATCH v4 2/2] ASoC: amd: acp: Add support for rt5682s and rt1019 card with hs instance V sujith kumar Reddy
2022-05-25 21:28 ` Pierre-Louis Bossart
2022-05-31 9:24 ` Reddy, V sujith kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e16d1f5-b466-2f4c-561f-aecf21e35458@amd.com \
--to=vsujithkumar.reddy@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=ajitkumar.pandey@amd.com \
--cc=akihiko.odaki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=baijiaju1990@gmail.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).