From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>,
broonie@kernel.org, alsa-devel@alsa-project.org
Cc: Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, ajitkumar.pandey@amd.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kai Vehmanen <kai.vehmanen@intel.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Arnd Bergmann <arnd@arndb.de>,
Jia-Ju Bai <baijiaju1990@gmail.com>,
Akihiko Odaki <akihiko.odaki@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] ASoC: amd: acp: Add support for nau8825 and max98360 card
Date: Wed, 25 May 2022 16:25:33 -0500 [thread overview]
Message-ID: <895302ec-f9e5-2b6a-835a-08e73ef8ace3@linux.intel.com> (raw)
In-Reply-To: <20220525203415.2227914-2-Vsujithkumar.Reddy@amd.com>
> +struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_sof_machines[] = {
> + {
> + .id = "AMDI1019",
> + .drv_name = "rmb-dsp",
> + .pdata = &acp_quirk_data,
> + .fw_filename = "sof-rmb.ri",
> + .sof_tplg_filename = "sof-acp-rmb.tplg",
> + },
> + {
> + .id = "10508825",
> + .drv_name = "nau8825-max",
> + .pdata = &acp_quirk_data,
> + .machine_quirk = snd_soc_acpi_codec_list,
> + .quirk_data = &_max,
> + .fw_filename = "sof-rmb.ri",
> + .sof_tplg_filename = "sof-acp-rmb.tplg",
this looks rather odd, you have two entries in the table that point to
the exact same pair of firmware and topology files. This is either
intentional and missing a comment, or a copy-paste mistake, or some of
these fields are not required.
> - clk_disable_unprepare(drvdata->wclk);
> + if (!drvdata->soc_mclk)
> + clk_disable_unprepare(drvdata->wclk);
> }
mclk and wclk are different concepts usually.
> struct acp_card_drvdata {
> @@ -49,6 +51,7 @@ struct acp_card_drvdata {
> unsigned int dai_fmt;
> struct clk *wclk;
> struct clk *bclk;
> + bool soc_mclk;
I wonder if soc_mclk means 'soc_clock_provider' ?
it looks like a configuration instead of a real/physical clock?
next prev parent reply other threads:[~2022-05-25 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220525203415.2227914-1-Vsujithkumar.Reddy@amd.com>
2022-05-25 20:34 ` [PATCH v4 1/2] ASoC: amd: acp: Add support for nau8825 and max98360 card V sujith kumar Reddy
2022-05-25 21:25 ` Pierre-Louis Bossart [this message]
2022-05-25 20:34 ` [PATCH v4 2/2] ASoC: amd: acp: Add support for rt5682s and rt1019 card with hs instance V sujith kumar Reddy
2022-05-25 21:28 ` Pierre-Louis Bossart
2022-05-31 9:24 ` Reddy, V sujith kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=895302ec-f9e5-2b6a-835a-08e73ef8ace3@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vsujithkumar.Reddy@amd.com \
--cc=ajitkumar.pandey@amd.com \
--cc=akihiko.odaki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=baijiaju1990@gmail.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=geert+renesas@glider.be \
--cc=kai.vehmanen@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).