From: Miaohe Lin <linmiaohe@huawei.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Luck, Tony" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH] mce: fix missing stack-dumping in mce_panic()
Date: Thu, 29 Dec 2022 20:33:55 +0800 [thread overview]
Message-ID: <1e97c11d-99b6-c06f-b67f-c56ba6653d27@huawei.com> (raw)
In-Reply-To: <Y61/+V47qH/8OVxp@zn.tnic>
On 2022/12/29 19:54, Borislav Petkov wrote:
> On Sat, Dec 03, 2022 at 10:19:32AM +0800, Miaohe Lin wrote:
>> So I think it's better to have at least one stack dumps. Also what the commit
>> 6e6f0a1f0fa6 ("panic: don't print redundant backtraces on oops") and commit
>> 026ee1f66aaa ("panic: fix stack dump print on direct call to panic()") want
>> to do is avoiding nested stack-dumping to have the original oops data being
>> scrolled away on a 80x50 screen but to have *at least one backtraces*. So
>> this patch acts more like a BUGFIX to ensure having at least one backtraces
>> in mce_panic().
>
Many thanks for your reply. :)
> So which commit broke this?
>
I think it should be Fixes: 6e6f0a1f0fa6 ("panic: don't print redundant backtraces on oops")
as there's missing stack-dumping in mce_panic() since then. Should I resend the patch with
above Fixes tag attached?
> One of the two above or
>
> 004429956b48 ("handle recursive calls to bust_spinlocks()")
>
> or
>
> d896a940ef4f ("x86, mce: remove oops_begin() use in 64bit machine check")
>
> or...?
>
> By looking at their dates, they're pretty much too old so that this can
> go to *all* stable kernels.
Yes, it should be a really old problem. And it seems it's unnoticed yet because mce should be a
really rare event and corresponding dump-stacking might not be that attractive at that time.
Thanks!
Miaohe Lin
next prev parent reply other threads:[~2022-12-29 12:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 16:37 [PATCH] mce: fix missing stack-dumping in mce_panic() Miaohe Lin
2022-12-02 14:44 ` Luck, Tony
2022-12-03 2:19 ` Miaohe Lin
2022-12-03 4:22 ` Tony Luck
2022-12-03 6:48 ` Miaohe Lin
2022-12-29 11:54 ` Borislav Petkov
2022-12-29 12:33 ` Miaohe Lin [this message]
2022-12-29 12:51 ` Borislav Petkov
2022-12-30 1:56 ` Miaohe Lin
2023-01-03 21:12 ` Luck, Tony
2023-01-06 1:57 ` Miaohe Lin
2023-01-06 17:42 ` Luck, Tony
2023-01-07 2:27 ` Miaohe Lin
2023-01-08 17:54 ` Luck, Tony
2023-01-09 2:16 ` Miaohe Lin
2023-01-09 4:45 ` Luck, Tony
2023-01-09 6:54 ` Miaohe Lin
2022-12-10 2:28 ` Miaohe Lin
2022-12-28 12:33 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e97c11d-99b6-c06f-b67f-c56ba6653d27@huawei.com \
--to=linmiaohe@huawei.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).