linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: <tony.luck@intel.com>, <bp@alien8.de>, <tglx@linutronix.de>,
	<mingo@redhat.com>, <dave.hansen@linux.intel.com>
Cc: <x86@kernel.org>, <hpa@zytor.com>, <linux-edac@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linmiaohe@huawei.com>
Subject: [PATCH] mce: fix missing stack-dumping in mce_panic()
Date: Sat, 3 Dec 2022 00:37:28 +0800	[thread overview]
Message-ID: <20221202163728.392509-1-linmiaohe@huawei.com> (raw)

When machine check exception occurs, there is no stack-dumping now in
mce_panic(). It's because bust_spinlocks(1) is called prematurely so
oops_in_progress will be >= 2 when trying to call dump_stack() in
panic(). Thus dump_stack() won't be called as this is considered as
nested stack-dumping.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 arch/x86/kernel/cpu/mce/core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 2c8ec5c71712..c40dad1a6749 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -254,7 +254,6 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp)
 			wait_for_panic();
 		barrier();
 
-		bust_spinlocks(1);
 		console_verbose();
 	} else {
 		/* Don't log too much for fake panic */
-- 
2.23.0


             reply	other threads:[~2022-12-02  8:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 16:37 Miaohe Lin [this message]
2022-12-02 14:44 ` [PATCH] mce: fix missing stack-dumping in mce_panic() Luck, Tony
2022-12-03  2:19   ` Miaohe Lin
2022-12-03  4:22     ` Tony Luck
2022-12-03  6:48       ` Miaohe Lin
2022-12-29 11:54     ` Borislav Petkov
2022-12-29 12:33       ` Miaohe Lin
2022-12-29 12:51         ` Borislav Petkov
2022-12-30  1:56           ` Miaohe Lin
2023-01-03 21:12             ` Luck, Tony
2023-01-06  1:57               ` Miaohe Lin
2023-01-06 17:42                 ` Luck, Tony
2023-01-07  2:27                   ` Miaohe Lin
2023-01-08 17:54                     ` Luck, Tony
2023-01-09  2:16                       ` Miaohe Lin
2023-01-09  4:45                         ` Luck, Tony
2023-01-09  6:54                           ` Miaohe Lin
2022-12-10  2:28 ` Miaohe Lin
2022-12-28 12:33   ` Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221202163728.392509-1-linmiaohe@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).