* [PATCH 1/1] dt-bindings: iommu: arm-smmu: Add binding for sm6125
@ 2022-10-01 18:57 Martin Botka
2022-10-02 8:17 ` Krzysztof Kozlowski
2022-10-04 12:59 ` Marijn Suijten
0 siblings, 2 replies; 3+ messages in thread
From: Martin Botka @ 2022-10-01 18:57 UTC (permalink / raw)
To: martin.botka1
Cc: ~postmarketos/upstreaming, Konrad Dybcio,
AngeloGioacchino Del Regno, Marijn Suijten, Jami Kettunen,
Paul Bouchara, Martin Botka, Will Deacon, Robin Murphy,
Joerg Roedel, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
iommu, devicetree, linux-kernel
This patch adds binding for sm6125 SoC
Signed-off-by: Martin Botka <martin.botka@somainline.org>
---
Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index 9066e6df1ba1..21e15b88bae7 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -41,6 +41,7 @@ properties:
- qcom,sdm845-smmu-500
- qcom,sdx55-smmu-500
- qcom,sdx65-smmu-500
+ - qcom,sm6125-smmu-500
- qcom,sm6350-smmu-500
- qcom,sm6375-smmu-500
- qcom,sm8150-smmu-500
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dt-bindings: iommu: arm-smmu: Add binding for sm6125
2022-10-01 18:57 [PATCH 1/1] dt-bindings: iommu: arm-smmu: Add binding for sm6125 Martin Botka
@ 2022-10-02 8:17 ` Krzysztof Kozlowski
2022-10-04 12:59 ` Marijn Suijten
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-02 8:17 UTC (permalink / raw)
To: Martin Botka, martin.botka1
Cc: ~postmarketos/upstreaming, Konrad Dybcio,
AngeloGioacchino Del Regno, Marijn Suijten, Jami Kettunen,
Paul Bouchara, Will Deacon, Robin Murphy, Joerg Roedel,
Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, iommu,
devicetree, linux-kernel
On 01/10/2022 20:57, Martin Botka wrote:
> This patch adds binding for sm6125 SoC
Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
Fix it in all your patches, please. It is just "Add binding for SM6125 SoC".
In the same time, your commit subject has redundant binding - first in
prefix, second (redundant) in "Add binding for". So just:
dt-bindings: iommu: arm-smmu: Add SM6125
Please fix both in all your patches.
>
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
With subject and commit msg fixes:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dt-bindings: iommu: arm-smmu: Add binding for sm6125
2022-10-01 18:57 [PATCH 1/1] dt-bindings: iommu: arm-smmu: Add binding for sm6125 Martin Botka
2022-10-02 8:17 ` Krzysztof Kozlowski
@ 2022-10-04 12:59 ` Marijn Suijten
1 sibling, 0 replies; 3+ messages in thread
From: Marijn Suijten @ 2022-10-04 12:59 UTC (permalink / raw)
To: Martin Botka
Cc: martin.botka1, ~postmarketos/upstreaming, Konrad Dybcio,
AngeloGioacchino Del Regno, Jami Kettunen, Paul Bouchara,
Will Deacon, Robin Murphy, Joerg Roedel, Rob Herring,
Krzysztof Kozlowski, linux-arm-kernel, iommu, devicetree,
linux-kernel
On 2022-10-01 20:57:15, Martin Botka wrote:
> This patch adds binding for sm6125 SoC
>
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> ---
> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index 9066e6df1ba1..21e15b88bae7 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -41,6 +41,7 @@ properties:
> - qcom,sdm845-smmu-500
> - qcom,sdx55-smmu-500
> - qcom,sdx65-smmu-500
> + - qcom,sm6125-smmu-500
Shouldn't this be in the list above given that you switched the APPS to
smmu-v2 in
https://lore.kernel.org/linux-arm-msm/20221001185750.495874-1-martin.botka@somainline.org/
Alas, I don't remember which of the two compatibles is correct for this
SoC, since both were seemingly working correctly...
- Marijn
> - qcom,sm6350-smmu-500
> - qcom,sm6375-smmu-500
> - qcom,sm8150-smmu-500
> --
> 2.37.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-04 13:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-01 18:57 [PATCH 1/1] dt-bindings: iommu: arm-smmu: Add binding for sm6125 Martin Botka
2022-10-02 8:17 ` Krzysztof Kozlowski
2022-10-04 12:59 ` Marijn Suijten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).