From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
davem@davemloft.net, jiri@resnulli.us, ivecera@redhat.com,
kuba@kernel.org, roopa@cumulusnetworks.com, olteanv@gmail.com,
andrew@lunn.ch, UNGLinuxDriver@microchip.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next v3 04/11] net: bridge: Add port attribute IFLA_BRPORT_MRP_RING_OPEN
Date: Fri, 24 Apr 2020 16:12:36 +0300 [thread overview]
Message-ID: <1f2767bf-8ca4-781f-b35a-1ed5a169c206@cumulusnetworks.com> (raw)
In-Reply-To: <20200422161833.1123-5-horatiu.vultur@microchip.com>
On 22/04/2020 19:18, Horatiu Vultur wrote:
> This patch adds a new port attribute, IFLA_BRPORT_MRP_RING_OPEN, which allows
> to notify the userspace when the port lost the continuite of MRP frames.
>
> This attribute is set by kernel whenever the SW or HW detects that the ring is
> being open or closed.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> include/uapi/linux/if_link.h | 1 +
> net/bridge/br_netlink.c | 3 +++
> tools/include/uapi/linux/if_link.h | 1 +
> 3 files changed, 5 insertions(+)
>
> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index 61e0801c82df..4a295deb933b 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -343,6 +343,7 @@ enum {
> IFLA_BRPORT_NEIGH_SUPPRESS,
> IFLA_BRPORT_ISOLATED,
> IFLA_BRPORT_BACKUP_PORT,
> + IFLA_BRPORT_MRP_RING_OPEN,
> __IFLA_BRPORT_MAX
> };
> #define IFLA_BRPORT_MAX (__IFLA_BRPORT_MAX - 1)
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index 43dab4066f91..4084f1ef8641 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -151,6 +151,7 @@ static inline size_t br_port_info_size(void)
> + nla_total_size(sizeof(u8)) /* IFLA_BRPORT_MULTICAST_ROUTER */
> #endif
> + nla_total_size(sizeof(u16)) /* IFLA_BRPORT_GROUP_FWD_MASK */
> + + nla_total_size(sizeof(u8)) /* IFLA_BRPORT_MRP_RING_OPEN */
> + 0;
> }
>
> @@ -213,6 +214,8 @@ static int br_port_fill_attrs(struct sk_buff *skb,
> nla_put_u16(skb, IFLA_BRPORT_GROUP_FWD_MASK, p->group_fwd_mask) ||
> nla_put_u8(skb, IFLA_BRPORT_NEIGH_SUPPRESS,
> !!(p->flags & BR_NEIGH_SUPPRESS)) ||
> + nla_put_u8(skb, IFLA_BRPORT_MRP_RING_OPEN, !!(p->flags &
> + BR_MRP_LOST_CONT)) ||
> nla_put_u8(skb, IFLA_BRPORT_ISOLATED, !!(p->flags & BR_ISOLATED)))
> return -EMSGSIZE;
>
> diff --git a/tools/include/uapi/linux/if_link.h b/tools/include/uapi/linux/if_link.h
> index 024af2d1d0af..70dae9ba16f4 100644
> --- a/tools/include/uapi/linux/if_link.h
> +++ b/tools/include/uapi/linux/if_link.h
> @@ -343,6 +343,7 @@ enum {
> IFLA_BRPORT_NEIGH_SUPPRESS,
> IFLA_BRPORT_ISOLATED,
> IFLA_BRPORT_BACKUP_PORT,
> + IFLA_BRPORT_MRP_RING_OPEN,
> __IFLA_BRPORT_MAX
> };
> #define IFLA_BRPORT_MAX (__IFLA_BRPORT_MAX - 1)
>
Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
next prev parent reply other threads:[~2020-04-24 13:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 16:18 [PATCH net-next v3 00/11] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP) Horatiu Vultur
2020-04-22 16:18 ` [PATCH net-next v3 01/11] bridge: uapi: mrp: Add mrp attributes Horatiu Vultur
2020-04-24 13:11 ` Nikolay Aleksandrov
2020-04-22 16:18 ` [PATCH net-next v3 02/11] bridge: mrp: Update Kconfig Horatiu Vultur
2020-04-24 13:11 ` Nikolay Aleksandrov
2020-04-22 16:18 ` [PATCH net-next v3 03/11] bridge: mrp: Extend bridge interface Horatiu Vultur
2020-04-24 13:11 ` Nikolay Aleksandrov
2020-04-22 16:18 ` [PATCH net-next v3 04/11] net: bridge: Add port attribute IFLA_BRPORT_MRP_RING_OPEN Horatiu Vultur
2020-04-24 13:12 ` Nikolay Aleksandrov [this message]
2020-04-22 16:18 ` [PATCH net-next v3 05/11] bridge: mrp: Add MRP interface Horatiu Vultur
2020-04-24 13:13 ` Nikolay Aleksandrov
2020-04-22 16:18 ` [PATCH net-next v3 06/11] switchdev: mrp: Extend switchdev API to offload MRP Horatiu Vultur
2020-04-22 16:18 ` [PATCH net-next v3 07/11] bridge: switchdev: mrp: Implement MRP API for switchdev Horatiu Vultur
2020-04-22 16:18 ` [PATCH net-next v3 08/11] bridge: mrp: Connect MRP API with the switchdev API Horatiu Vultur
2020-04-24 13:47 ` Nikolay Aleksandrov
2020-04-25 8:57 ` Horatiu Vultur
2020-04-22 16:18 ` [PATCH net-next v3 09/11] bridge: mrp: Implement netlink interface to configure MRP Horatiu Vultur
2020-04-22 16:18 ` [PATCH net-next v3 10/11] bridge: mrp: Integrate MRP into the bridge Horatiu Vultur
2020-04-24 13:49 ` Nikolay Aleksandrov
2020-04-22 16:18 ` [PATCH net-next v3 11/11] net: bridge: Add checks for enabling the STP Horatiu Vultur
2020-04-24 13:20 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f2767bf-8ca4-781f-b35a-1ed5a169c206@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=horatiu.vultur@microchip.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).