Re: [PATCH net-next v3 10/11] bridge: mrp: Integrate MRP into the bridge

From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
	davem@davemloft.net, jiri@resnulli.us, ivecera@redhat.com,
	kuba@kernel.org, roopa@cumulusnetworks.com, olteanv@gmail.com,
	andrew@lunn.ch, UNGLinuxDriver@microchip.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next v3 10/11] bridge: mrp: Integrate MRP into the bridge
Date: Fri, 24 Apr 2020 16:49:09 +0300	[thread overview]
Message-ID: <4c2200b5-5173-eac3-1cf5-14538a0b5d71@cumulusnetworks.com> (raw)
In-Reply-To: <20200422161833.1123-11-horatiu.vultur@microchip.com>

On 22/04/2020 19:18, Horatiu Vultur wrote:
> To integrate MRP into the bridge, the bridge needs to do the following:
> - detect if the MRP frame was received on MRP ring port in that case it would be
>   processed otherwise just forward it as usual.
> - enable parsing of MRP
> - before whenever the bridge was set up, it would set all the ports in
>   forwarding state. Add an extra check to not set ports in forwarding state if
>   the port is an MRP ring port. The reason of this change is that if the MRP
>   instance initially sets the port in blocked state by setting the bridge up it
>   would overwrite this setting.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  net/bridge/br_device.c  |  3 +++
>  net/bridge/br_if.c      |  2 ++
>  net/bridge/br_input.c   |  3 +++
>  net/bridge/br_netlink.c |  5 +++++
>  net/bridge/br_private.h | 31 +++++++++++++++++++++++++++++++
>  5 files changed, 44 insertions(+)
> 

Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>