From: Joe Perches <joe@perches.com>
To: Nicolai Fischer <nicolai.fischer@fau.de>, linux-kernel@vger.kernel.org
Cc: apw@canonical.com, johannes.czekay@fau.de, linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH 2/2] checkpatch: kconfig: add missing types to regex
Date: Sun, 20 Dec 2020 11:16:11 -0800 [thread overview]
Message-ID: <1f3b50a6f343dd252c043b2e5b7d47bca8514ee7.camel@perches.com> (raw)
In-Reply-To: <a9797282-84c3-2c8f-73a0-d751a8201541@fau.de>
On Mon, 2020-12-14 at 11:24 +0100, Nicolai Fischer wrote:
> Kconfig parsing does not recognise all type attributes.
> This adds the missing 'int', 'sting' and 'hex' types.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3321,7 +3321,7 @@ sub process {
> next if ($f =~ /^-/);
> last if (!$file && $f =~ /^\@\@/);
>
>
> - if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) {
> + if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|int|hex|string|prompt)\s*["']/) {
> $is_start = 1;
> } elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
> $length = -1;
Another thing that could be done is to enforce the "extra 2 spaces"
indent by capturing the whitespace before the help keyword:
} elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
could be
} elsif ($lines[$ln - 1] =~ /^\+(\s*)help\s*$/) {
with $1 used to validate the extra indent.
next prev parent reply other threads:[~2020-12-20 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 10:24 [PATCH 2/2] checkpatch: kconfig: add missing types to regex Nicolai Fischer
2020-12-20 19:12 ` Joe Perches
2020-12-20 19:16 ` Joe Perches [this message]
2020-12-21 15:08 ` Nicolai Fischer
2020-12-21 17:17 ` Joe Perches
2020-12-25 17:27 ` Nicolai Fischer
2020-12-25 17:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f3b50a6f343dd252c043b2e5b7d47bca8514ee7.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=johannes.czekay@fau.de \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolai.fischer@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).